Project

General

Profile

Actions

Task #102103

open

Refactor TS IncludeTree condition detail

Added by Christian Kuhn 7 months ago. Updated 7 months ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2023-10-06
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Similar to #102102

The "condition" include object tree structure should be improved: A "body" include should be added as child of the condition that represents the executed body when the condition matches. The condition object itself should just contain the condition snipped. Also, the body include should then have the according body line objects set, those are currently not added at all and are only attached to the parent include, which makes everything harder than it should be, especially in IncludeTreeSyntaxScannerVisitor, and in BE module source rendering.

This change should probably be done before #102102 to simplify the needed IncludeTreeSyntaxScannerVisitor refactoring.

Sidenote: We may want to change [global] and [end] to single objects, too. I think we fiddled in this area once already, but still, it might be good to reconsider again. Having an own object for this would probably simplify the ast builder, may reduce some headaches with source rendering, and would simplify a possible detection of "double" [globals] as well, which could be implemented in IncludeTreeSyntaxScannerVisitor.


Related issues 3 (1 open2 closed)

Related to TYPO3 Core - Feature #97816: New TypoScript parserClosed2022-06-27

Actions
Related to TYPO3 Core - Task #102102: Refactor TS IncludeTree Import detailNew2023-10-06

Actions
Related to TYPO3 Core - Bug #102064: TypoScript module does not report errorsResolved2023-09-29

Actions
Actions #1

Updated by Christian Kuhn 7 months ago

Actions #2

Updated by Christian Kuhn 7 months ago

  • Related to Task #102102: Refactor TS IncludeTree Import detail added
Actions #3

Updated by Christian Kuhn 7 months ago

  • Related to Bug #102064: TypoScript module does not report errors added
Actions #4

Updated by Christian Kuhn 7 months ago

  • Description updated (diff)
Actions

Also available in: Atom PDF