Project

General

Profile

Actions

Bug #102064

closed

TypoScript module does not report errors

Added by Markus Klein 7 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
TypoScript
Target version:
-
Start date:
2023-09-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Using an invalid import in TS does not cause any integrator feedback.

I would expect that either "Active TypoScript" or "Included TypoScript" would warn me about invalid TS.

Example of invalid import (path traversal):
<INCLUDE_TYPOSCRIPT: source="DIR:../global/Setup/">


Related issues 7 (2 open5 closed)

Related to TYPO3 Core - Bug #94695: Template Analyzer stoped Highlighting syntax errorsClosed2021-08-02

Actions
Related to TYPO3 Core - Bug #102065: Invalid TypoScript import causes the complete file to be ignoredResolvedMarkus Klein2023-09-29

Actions
Related to TYPO3 Core - Feature #97816: New TypoScript parserClosed2022-06-27

Actions
Related to TYPO3 Core - Feature #100218: Basic TypoScript syntax scannerClosed2023-03-20

Actions
Related to TYPO3 Core - Task #102102: Refactor TS IncludeTree Import detailNew2023-10-06

Actions
Related to TYPO3 Core - Task #102103: Refactor TS IncludeTree condition detailNew2023-10-06

Actions
Related to TYPO3 Core - Bug #102191: Missing error messages for failed imports in TypoScript moduleClosed2023-10-17

Actions
Actions #1

Updated by Markus Klein 7 months ago

  • Related to Bug #94695: Template Analyzer stoped Highlighting syntax errors added
Actions #2

Updated by Markus Klein 7 months ago

  • Related to Bug #102065: Invalid TypoScript import causes the complete file to be ignored added
Actions #3

Updated by Markus Klein 7 months ago

https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php#L437

should probably trigger the error

Actions #4

Updated by Christian Kuhn 7 months ago

Actions #5

Updated by Christian Kuhn 7 months ago

Actions #6

Updated by Christian Kuhn 7 months ago

IncludeTreeSyntaxScannerVisitor :) See #100218. I'll try to implement something.

Actions #7

Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81352

Actions #8

Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81352

Actions #9

Updated by Christian Kuhn 7 months ago

  • Related to Task #102102: Refactor TS IncludeTree Import detail added
Actions #10

Updated by Christian Kuhn 7 months ago

  • Related to Task #102103: Refactor TS IncludeTree condition detail added
Actions #11

Updated by Gerrit Code Review 7 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81352

Actions #12

Updated by Gerrit Code Review 7 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81352

Actions #13

Updated by Gerrit Code Review 7 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81352

Actions #14

Updated by Gerrit Code Review 7 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81358

Actions #15

Updated by Christian Kuhn 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #16

Updated by Christian Kuhn 6 months ago

  • Related to Bug #102191: Missing error messages for failed imports in TypoScript module added
Actions

Also available in: Atom PDF