Project

General

Profile

Actions

Bug #102176

open

Missing error suppression for preg_match in RedirectService

Added by Moritz Noll 7 months ago. Updated 7 months ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
Redirect Handling
Target version:
-
Start date:
2023-10-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
7.4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

You have a missing '@' sign in front of preg_match like the lines before to suppress the errors.
https://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/main/entry/typo3/sysext/redirects/Classes/Service/RedirectService.php#L162
I was able to raise an error there by calling an URL with parameter.


Files

exception.png (43.9 KB) exception.png Moritz Noll, 2023-10-16 09:45
Actions #1

Updated by Chris Müller 7 months ago

  • Status changed from New to Needs Feedback

Suppressing an error might not be the best way.

Can you give more information which error was raised and how your URL looked like?

Actions #2

Updated by Moritz Noll 7 months ago

I called the URL 'http://localhost/xxx-shop/shop?ai[f_name]=ABC&ai[f_catid]=3&ai[controller]=Catalog&ai[action]=list'.
The error occurs at the linked line above.
In the attachment you see the error page.
Because in the same function the other both preg_macth calls are prefixed with '@' I've think that this one was forgotten.

Actions #3

Updated by Chris Müller 7 months ago

  • Status changed from Needs Feedback to New
Actions

Also available in: Atom PDF