Bug #102176
closed
Missing error suppression for preg_match in RedirectService
100%
Description
You have a missing '@' sign in front of preg_match like the lines before to suppress the errors.
https://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/main/entry/typo3/sysext/redirects/Classes/Service/RedirectService.php#L162
I was able to raise an error there by calling an URL with parameter.
Files
Updated by Chris Müller 9 months ago
- Status changed from New to Needs Feedback
Suppressing an error might not be the best way.
Can you give more information which error was raised and how your URL looked like?
Updated by Moritz Noll 9 months ago
- File exception.png exception.png added
I called the URL 'http://localhost/xxx-shop/shop?ai[f_name]=ABC&ai[f_catid]=3&ai[controller]=Catalog&ai[action]=list'.
The error occurs at the linked line above.
In the attachment you see the error page.
Because in the same function the other both preg_macth calls are prefixed with '@' I've think that this one was forgotten.
Updated by Gerrit Code Review 7 days ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84872
Updated by Gerrit Code Review 7 days ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84872
Updated by Gerrit Code Review 7 days ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84872
Updated by Gerrit Code Review 6 days ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84872
Updated by Garvin Hicking 6 days ago
- Related to Bug #104190: restrict "Unsafe captching group regex"-message to only used replacements added
Updated by Gerrit Code Review 5 days ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84842
Updated by Gerrit Code Review 5 days ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84843
Updated by Stefan Bürk 5 days ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6c88f15e7e06475bb7c0fe0743d1b92c206ee8b0.