Project

General

Profile

Actions

Task #102329

open

Modal "Remove Temporary Assets" can't be closed with ESC when assets were removed

Added by Christoph Lehmann 6 months ago. Updated 6 months ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2023-11-06
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Visit /typo3/module/tools/maintenance and click on "scan temporary files" to open the modal "Remove Temporary Assets"

Here click a button to remove some assets.

A flash message pops up and the dialog can not be closed with ESC on keyboard.

You have to wait until the Flash message is removed to close the modal with ESC.


Side topic: It would be very nice, when the modal can be closed with a mouse click outside the modal. Currently the user is forced to use ESC or to navigate to the small 'x' in the top right corner.

Actions #1

Updated by Marcin Sągol 6 months ago

I'm not sure if clicking outside a modal should trigger its closing action.
As you can see, all modals in the Maintenance module function this way.
Given that the Maintenance module is more important and has a higher impact on the website than modals in other non-admin modules, I think maintaining the current behavior might be better.
This approach prevents accidentally closing the modal by clicking outside of it. What do you think?

Actions #2

Updated by Christoph Lehmann 6 months ago

I would ignore "accidently clicking". Given you support it... where to start, where to end?

Lets focus on keyboard navigation. It would help, when new flash messages dont get focused automatically, eg the focus stay on the modal. What do you think?

Actions #3

Updated by Oliver Bartsch 6 months ago

I just checked the behaviour. It's actually not the flash message, which prevents closing using ESC key. The focus remains on the clicked button.

Actions

Also available in: Atom PDF