Project

General

Profile

Actions

Bug #102750

closed

addRecord pid ###SITE:<KEY>.<SUBKEY>### does not work

Added by Daniel Siepmann 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend API
Target version:
-
Start date:
2024-01-04
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The documentation https://docs.typo3.org/m/typo3/reference-tca/12.4/en-us/ColumnsConfig/CommonProperties/FieldControl/AddRecord.html#confval-options-pid says one should check out https://docs.typo3.org/m/typo3/reference-tca/12.4/en-us/ColumnsConfig/Type/Select/Properties/ForeignTableWhere.html#field-quoting which offers

###SITE:<KEY>.<SUBKEY>###
which is not resolved right now. It is passed to Classes/Controller/Wizard/AddController.php which doesn't resolve the marker.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #94662: Add placeholder for site configuration in foreign_where_tableClosedFrank Nägler2021-07-29

Actions
Actions #1

Updated by Oliver Bartsch 11 months ago

Thats actually wrong in the documentation. The mentioned syntax has never been implemented for the AddRecord FieldControl. I assume https://docs.typo3.org/m/typo3/reference-tca/12.4/en-us/ColumnsConfig/CommonProperties/FieldControl/AddRecord.html#confval-options-pid referenced https://docs.typo3.org/m/typo3/reference-tca/12.4/en-us/ColumnsConfig/Type/Select/Properties/ForeignTableWhere.html#field-quoting before the new site setting has been added as option. Actually, we are about to not introduce additional marker based placeholders for those FieldControl's. I therefore suggest to adjust the docs instead.

Best, Oli

Actions #2

Updated by Oliver Bartsch 11 months ago

  • Status changed from New to Needs Feedback
Actions #3

Updated by Daniel Siepmann 11 months ago

  • Status changed from Needs Feedback to Closed

Okay, there is a workaround anyway with existing markers.

I'll open an issue for the docs instead.

Actions #5

Updated by Chris Müller 11 months ago · Edited

  • Status changed from Closed to New

Actually, it is mentioned in a changelog for v11:
https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.4/Feature-94662-AddPlaceholderForSiteConfigurationInForeignTableWhere.html

So, if this is not implemented, it should be removed there.

Actions #6

Updated by Chris Müller 11 months ago

  • Assignee set to Chris Müller
Actions #7

Updated by Chris Müller 11 months ago

  • Related to Feature #94662: Add placeholder for site configuration in foreign_where_table added
Actions #8

Updated by Gerrit Code Review 11 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82333

Actions #9

Updated by Oliver Bartsch 11 months ago

  • Status changed from Under Review to Needs Feedback

Chris Müller wrote in #note-5:

Actually, it is mentioned in a changelog for v11:
https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.4/Feature-94662-AddPlaceholderForSiteConfigurationInForeignTableWhere.html

So, if this is not implemented, it should be removed there.

Hi Chris, I fear there is a misunderstanding regarding the reported issue. The feature does not work for the AddRecord wizard but does work for the foreign_table_where option as advertised in the changelog. I just checked this and there are also tests in place, covering this scenario, see: https://github.com/TYPO3/typo3/blob/main/typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php#L1079

Actions #10

Updated by Chris Müller 11 months ago

Ah okay, thanks for the clarification.

Actions #11

Updated by Chris Müller 11 months ago

  • Status changed from Needs Feedback to Closed
Actions

Also available in: Atom PDF