Project

General

Profile

Actions
Copy link

Bug #102751

closed

AbstractUserAuthentication: Missing condition for empty checkPid_value

Added by Sven Proffe 7 months ago. Updated 8 days ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Authentication
Target version:
-
Start date:
2024-01-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In TYPO3\CMS\Core\Authentication\AbstractUserAuthentication, line 919 reads (as of current main):

if ($this->checkPid && $this->checkPid_value !== null) {

As $this->checkPid_value may be a string it may be empty, which is not checked. In that case TYPO3\CMS\Core\Authentication\AbstractAuthenticationService->fetchUserRecord() will end up with a corrupt SQL query containing a restriction like ... AND pid in ()...

So, I'd like to suggest to check for an empty string, as well.

if ($this->checkPid && $this->checkPid_value !== null && $this->checkPid_value !== '') {

Actions
Copy link

Also available in: Atom PDF