Project

General

Profile

Actions

Task #102807

closed

Avoid invalid datetime database default in a test

Added by Stefan Bürk 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Tests
Target version:
-
Start date:
2024-01-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

With #102479 support for persisting datetime_immutable
object has been ensured and covered with a functional
test. However, using a empty string as default for a
not nullable datetime field is invalid for MariaDB and
MySQL which seamed to work until now in test executions.

Something has changed, but had no luck to find any traces
in the mariadb, mysql or corresponding docker hub changelogs
and commits explaining this.

The TYPO3 default TCA schema creates nullable fields with a
null default for `date, datetime and timestamp` anyway, and
therefore we now use that for the test case table structure.

It make sense to test a valid structure if working state is
expected.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #102479: Persisting DateTimeImmutable values results in DBAL ConversionExceptionClosedAndreas Wolf2023-11-23

Actions
Actions #1

Updated by Stefan Bürk 6 months ago

  • Related to Bug #102479: Persisting DateTimeImmutable values results in DBAL ConversionException added
Actions #2

Updated by Gerrit Code Review 6 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82423

Actions #3

Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82423

Actions #4

Updated by Gerrit Code Review 6 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82388

Actions #5

Updated by Stefan Bürk 6 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack 6 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF