Bug #102846
closed
Error with pidList in suggestOptions for group field in FlexForms
100%
Description
When I add suggestOptions for a group field in a content flexform, the search returns no results.
The ajax request returns a warning:
PHP Warning: Undefined array key "" in vendor/typo3/cms-backend/Classes/Controller/Wizard/SuggestWizardController.php line 62
When I debug the code it turns out that the
$parsedBody = $request->getParsedBody();is null so that the data will never be evaluated as flexform
if (empty($dataStructureIdentifier)) {is always true.
Updated by Stefan Terborg 6 months ago
- Subject changed from SuggestOptions for group field in FlexForms broken to Error with pidList in suggestOptions for group field in FlexForms
I´m sorry, it seems I looked at the wrong place. ParsedBody is not null and the suggest options work.
Instead there seems to be a problem with <pidList> causing the following error:
Argument #2 must be of type array, int given, in file vendor/typo3/cms-backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php:115
Example code:
...
<suggestOptions>
<default>
<pidList>33,41</pidList>
</default>
</suggestOptions>
...
Or maybe I'm missing some option for the usage with pidList.
Updated by Kai Strecker 2 months ago
- Complexity set to no-brainer
I have also just come across this bug.
As Stefan Terborg already pointed out, the cause is vendor/typo3/cms-backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php:115, which is this line of code:
$this->allowedPages = array_unique(array_merge($this->allowedPages, ...$availablePageIds));
The bug here is that
$availablePageIds is a one-dimensional array. Therefore, the use of ... to pass the array values to array_merge is incorrect. The fix is to simply remove ...:$this->allowedPages = array_unique(array_merge($this->allowedPages, $availablePageIds));
After doing this patch, the suggest wizard worked fine in my TYPO3 instance.
Updated by Georg Ringer about 1 month ago
can be tested in styleguide in:
- flexforms: flex_1 > group_db_2
- tca: group_db_10
Updated by Gerrit Code Review about 1 month ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84629
Updated by Gerrit Code Review 2 days ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84629
Updated by Gerrit Code Review 2 days ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85202
Updated by Georg Ringer 2 days ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 660c8621b3ebe42cc4139e279253935c036b1a04.