Project

General

Profile

Actions

Bug #103111

open

processor_stripColorProfileParameters splits up single value into multiple values

Added by Stefan Wagler 2 months ago. Updated 2 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2024-02-13
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

When migrating from the previous "GFX / processor_stripColorProfileCommand" to the new "GFX / processor_stripColorProfileParameters" configuration, it no longer seems possible to use a value like "+profile '!iptc,*'" via the TYPO3 Install Tool.
When the actual value contains a comma, the Install Tool splits the otherwise single parameter "!iptc,*" into two parameters "!iptc" and "*".

How is the intended usage to configure such parameters in the new "processor_stripColorProfileParameters" style?

Actions #1

Updated by Chris Müller 2 months ago

  • Subject changed from processor_stripColorProfileParameters spits up single value into multiple values to processor_stripColorProfileParameters splits up single value into multiple values
Actions #2

Updated by Markus Klein 2 months ago

First entry should be +profile second array entry should be !iptc,* in the new config.

The parsing bug should be fixed.

Actions #4

Updated by Markus Klein 2 months ago

  • Target version deleted (next-patchlevel)

@Stefan Wagler Can you please post here, how you configured 'processor_stripColorProfileParameters' exactly?

Actions #5

Updated by Stefan Wagler 2 months ago · Edited

We use the following configuration entry in the "GFX" section of the "settings.php" file:
'processor_stripColorProfileCommand' => '+profile \'!iptc,*\'',

When using the Install Tool and set the following option for "[GFX][processor_stripColorProfileParameters]":
+profile '!iptc,*'

the "settings.php" file contains the following entry:

'processor_stripColorProfileParameters' => [
'+profile \'!iptc',
'*\'',
],

Note the second parameter '!iptc,*' exists partly in the first array entry as well as in the second entry.

Actions #6

Updated by Markus Klein 2 months ago · Edited

  • Status changed from New to Accepted

Thanks for the clarification.

When using the Install Tool and set the following option for "[GFX][processor_stripColorProfileParameters]": +profile '!iptc,*'

This is wrong. As documented for this setting (Comma separated list of parameters), you should enter +profile,"!iptc,*".

Workaround: one should be able to fix this by manually changing the settings.php file.

Regard the parsing bug: The Install Tool needs to cope with quoted parts in such comma-separated lists.

Actions #7

Updated by Gerrit Code Review 2 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83003

Actions #8

Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83003

Actions

Also available in: Atom PDF