Task #103136
closedShow sender email address for mailtest in ext:install
100%
Description
The EnvironmentController
of ext:install assigns the variable mailTestSenderAddress
to the Fluid view. The variable is however not used, since it was migrated with a wrong name to ext:install in TYPO3 9.0.0. Previously in TYPO3 versions < v9, the variable was called senderEmailAddress
and the MailTest.html
template showed the sender email address to the user. Since the expected variable was empty, the text You should then receive a test email from "{senderEmailAddress}".
had no meaning and was removed with #88523
The mail test should however show the sending email address, so that users will know the current configured sending address. It should also be noticed, that not receiving the test email also might be a result of a spamfilter or domain configuration (e.g. SPF record).
Additionally, the notice $GLOBALS['TYPO3_CONF_VARS']['MAIL']['transport']['defaultMailFromAddress'] must be a valid email address.
is superfluous, since this is already checked in EnvironmentController
.
Finally, the fluid variable queueIdentifier
is never used at some place and can be removed.
Updated by Gerrit Code Review 9 months ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83021
Updated by Gerrit Code Review 9 months ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83021
Updated by Gerrit Code Review 9 months ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83021
Updated by Gerrit Code Review 9 months ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83021
Updated by Gerrit Code Review 9 months ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82989
Updated by Torben Hansen 9 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1d6aaf77426792886976f71eac8213687872dd3e.