Bug #103663
closedBroken icons in Content Element wizard with auto registration
100%
Description
Since #102834 content elements are registered automatically for the content element wizard (which is a great thing!!).
However if no icon is provided during ExtensionUtility::registerPlugin
a broken icon is rendered. IMO no icon or a default icon should be rendered then.
I tracked it down that in NewContentElementController
the wizard is populated with
$wizardEntry = [ 'iconIdentifier' => $selectItem->getIcon(), 'title' => $selectItem->getLabel(), 'description' => $itemDescription['description'] ?? ($itemDescription ?? ''), ];
but in ExtensionManagementUtility
the following lines
if (!$selectItem->hasIcon()) { $iconPath = static::$packageManager->getPackage($extensionKey)->getPackageIcon(); if ($iconPath) { $selectItem = $selectItem->withIcon('EXT:' . $extensionKey . '/' . $iconPath); } }
fills the icon with e.g. EXT:news/Resources/Public/Icons/Extension.svg
but the NewContentElementController can only handle icon identifiers.
IMHO the selectitem should never fallback to a path and just have no icon. otherwise there might be lots of places where it again needs to be checked if it is an icon path or an icon identifier
this can be tested by changing e.g. in typo3/sysext/felogin/Configuration/TCA/Overrides/tt_content.php
line 10 ('mimetypes-x-content-login',
) into null,
Files
Updated by Georg Ringer 7 months ago
- Related to Feature #102834: Auto-registration of NewContentElementWizard via TCA added
Updated by Gerrit Code Review 4 months ago
- Status changed from Accepted to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85396
Updated by Gerrit Code Review 4 months ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85396
Updated by Gerrit Code Review 4 months ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85396
Updated by Gerrit Code Review 4 months ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85396
Updated by Gerrit Code Review 4 months ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85396
Updated by Gerrit Code Review 4 months ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85396
Updated by Gerrit Code Review 4 months ago
Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85396
Updated by Gerrit Code Review 4 months ago
Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85396
Updated by Georg Ringer 4 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 17019d607d4eff606e4631609321757b013774a2.
Updated by Oliver Bartsch 4 months ago
- Related to Bug #104558: Render empty icon instead of invalid identifier added