Task #103668: Avoid usage of ConnectionPool in extbase functional tests - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #103668

closed

Avoid usage of ConnectionPool in extbase functional tests

Added by Torben Hansen 7 months ago. Updated 5 months ago.

Status:

Closed

Priority:

Should have

Assignee:

Torben Hansen

Category:

Extbase

Target version:

Start date:

2024-04-18

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

It should be avoided to verify test results using ConnectionPool and direct database queries. Instead, $this->assertCSVDataSet should be used.

Actions

Copy link

Updated by Christian Kuhn 7 months ago

I'd say: It depends ... I guess there are situations where firing a query to assert DB state is fine.

But I've also seen places - especially in extbase tests like persistence stuff - that would benefit when they assert csv files instead, and I remember I already changed various of them towards this. Please go ahead and do more.

Actions

Copy link

Updated by Gerrit Code Review 7 months ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84153

Actions

Copy link