Project

General

Profile

Actions

Bug #103825

closed

Undefined array key "foreign_table" in TcaInputPlaceholders

Added by Robert Vock 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2024-05-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
8.0
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When you're using a select field as placeholder for a textfield in TCA, you get an Undefined array key "foreign_table" in TcaInputPlaceholders warning in PHP 8.

TCA:


$GLOBALS['TCA']['tt_content']['columns']['fieldname'] = [
    'label' => 'Fieldlabel',
    'config' => [
        'type' => 'input',
        'eval' => 'trim',
        'placeholder' => '__row|CType',
    ],
];

Relevant Code-Position:
https://github.com/TYPO3/typo3/blob/2acd0592d211663ba3d29cb2aafe1344d04f9f0b/typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php#L123

switch ($fieldConfig['type']) {
    case 'select':
    case 'category':
        // The FormDataProviders already resolved the select items to an array of uids,
        // filter out empty values that occur when no related record has been selected.
        $possibleUids = array_filter($value);
        $foreignTableName = $fieldConfig['foreign_table'];
        break;

It's not guaranteed, that the foreign_table key is set for all select types.

Actions #1

Updated by Gerrit Code Review 6 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84391

Actions #2

Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84391

Actions #3

Updated by Gerrit Code Review 6 months ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84394

Actions #4

Updated by Gerrit Code Review 6 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84395

Actions #5

Updated by Georg Ringer 6 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF