Bug #104066: Remove invalid intendation style inside SiteConfiguration Overview - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Actions

Copy link

Bug #104066

closed

Remove invalid intendation style inside SiteConfiguration Overview

Added by Michael Telgkamp 5 months ago. Updated 5 months ago.

Status:

Closed

Priority:

Must have

Assignee:

Michael Telgkamp

Category:

Target version:

Start date:

2024-06-12

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Files

Screenshot from 2024-06-12 22-04-04.png (60.9 KB) Screenshot from 2024-06-12 22-04-04.png

Christian Kuhn, 2024-06-12 20:04

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Gerrit Code Review 5 months ago

Status changed from In Progress to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84671

Actions

Copy link

Updated by Michael Telgkamp 5 months ago

In the `for` loop the variable `rootPage` is set, but outside the loop `rootLinePage` is used for the style definition.

Actions

Copy link

Updated by Christian Kuhn 5 months ago

File Screenshot from 2024-06-12 22-04-04.png Screenshot from 2024-06-12 22-04-04.png added

Actions

Copy link

Updated by Christian Kuhn 5 months ago

is this nesting intended?

Actions

Copy link

Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84671

Actions

Copy link

Updated by Michael Telgkamp 5 months ago

Subject changed from Wrong variable name used in inline style inside SiteConfiguration Overview to Remove invalid intendation style inside SiteConfiguration Overview

Remove the inline style completely as it was not used since 12.3
Additionally the margin computation can be removed.

Actions

Copy link

Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84635

Actions

Copy link