Project

General

Profile

Actions

Bug #104222

closed

TypoScript import do not recognize historical file names

Added by Thorben Nissen 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
TypoScript
Start date:
2024-06-26
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
typoscript, parser, setup.txt, constants.txt
Complexity:
medium
Is Regression:
Sprint Focus:
Needs Decision

Description

The new TypoScript parser does not recognize historical TypoScript files names like `constants.txt`, `setup.txt` or `*.ts` during processing of the `@import` directives.

As these filenames and extensions are still supported in some parts of the application, the `@import` directives should recognize them too.

Actions #1

Updated by Georg Ringer 5 months ago

  • Sprint Focus set to Needs Decision
Actions #2

Updated by Garvin Hicking 5 months ago

  • Status changed from New to Needs Feedback

I think the intent here is to rather drop the old file formats everywhere and go forward with the new file extensions everywhere.

Where does the old syntax still work that you refer to?

Actions #3

Updated by Thorben Nissen 5 months ago

@Garvin Hicking Both the static file include from `sys_template` and the old `<INCLUDE_TYPOSCRIPT...>` syntax allow for including `setup.txt` files.

I agree, that it would be a good idea to remove the old `<INCLUDE_TYPOSCRIPT...>` syntax and old `.txt` file extensions. I guess that must be deprecated first with v14 and then removed in v15, meaning we would have v12, v13 and v14 which still supports the old syntax and therefore the `@import` should support it too.

Actions #4

Updated by Gerrit Code Review 5 months ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84939

Actions #5

Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84939

Actions #6

Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84939

Actions #7

Updated by Garvin Hicking 5 months ago

  • Status changed from Under Review to Closed

Thank you for the feedback and also the work you put into deliver a patch for it, much appreciated.

The feedback in the patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/84939 is rather specific and I believe this change will not find its way into the Core at this time. I hope it's ok with you to thus close this issue for the time being.

If the discussion in the patch itself goes into a different direction, this issue will automatically be set to 'resolved' though :-)

Actions

Also available in: Atom PDF