Project

General

Profile

Actions

Bug #104314

closed

Editors of element no more preselected for notifications when publishing in workspaces

Added by Hannes Bochmann 22 days ago. Updated 21 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2024-07-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In TYPO3 10.4 all editors that changed/worked on an element, were preselected for notifications when publishing to live. Of course this has to be configured accordingly for it to work. In TYPO3 12.4 (maybe even 11.5) even if everything is configured correct the editor of a change is not preselected when publishing an element. This does no longer work because of a bug in TYPO3\CMS\Workspaces\Service\RecordService::getCreateUserIds(). The field in the history record that is checked should be "usertype" and not "actiontype". When this is fixed the preselection works again.


Files

workspace-send-to-patched.png (93.2 KB) workspace-send-to-patched.png Garvin Hicking, 2024-07-06 21:29
workspace-publish.png (204 KB) workspace-publish.png Garvin Hicking, 2024-07-06 21:29
workspace-notification.png (256 KB) workspace-notification.png Garvin Hicking, 2024-07-06 21:29
workspace-send-to-unpatched.png (91.4 KB) workspace-send-to-unpatched.png Garvin Hicking, 2024-07-06 21:30

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #104228: "Recycler" backend module: The value of the owner data is always "(0)"ClosedJasmina Ließmann2024-06-26

Actions
Related to TYPO3 Core - Task #98024: Remove TCA option "cruser_id"Closed2022-07-26

Actions
Actions #1

Updated by Garvin Hicking 22 days ago

  • Related to Bug #104228: "Recycler" backend module: The value of the owner data is always "(0)" added
Actions #2

Updated by Garvin Hicking 22 days ago

  • Related to Task #98024: Remove TCA option "cruser_id" added
Actions #3

Updated by Gerrit Code Review 22 days ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85133

Updated by Garvin Hicking 21 days ago

To reproduce this:

Prerequisites

  • Have a pool of several backend users, for example: user1, user2, user3, user4, user5 (they all need to have email addresses set)

Create workspace and settings

  • Create a workspace, pick a card name, any name.
  • Edit workspace settings
  • In the tab "General" assign all 3 people as members. Set "Notification settings during state change" to "Notify all users on any change"
  • IMPORTANT: In the tab "Internal Stages", only enable "[x] Editors" for all three "Pre-select recipients" stages!

Create records

  • Activate workspace you created.
  • Select a page to edit in "Page" module.
  • As user1, create content on the page
  • Fast-user-switch to user2. Ensure workspace is still selected. Create some other content.
  • Fast-user-switch to user3. Ensure workspace is still selected. Create some other content.

Publish

  • Switch back to user1
  • Go to "Workspace" module
  • "Select all" content elements
  • In the dropdown above the list, for "Selection:" where it says "Choose staging action", pick "Publish to LIVE"

Verify

  • A popup opens showing user1 to 5
  • Without patch: No user is pre-selected
  • With patch: The users 1-3 will be pre-selected, users4 and 5 not (because they did not change content)
Actions #5

Updated by Gerrit Code Review 21 days ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85144

Actions #6

Updated by Garvin Hicking 21 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF