Project

General

Profile

Actions
Copy link

Bug #104345

closed

Composer installation of a Root Package does not properly store packagePath

Added by Garvin Hicking 4 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Must have
Assignee:
Garvin Hicking
Category:
composer
Target version:
next-patchlevel
Start date:
2024-07-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

The created PackageArtifact.php file currently stores "//" as packagePath for the composer root package. This path makes further usage buggy, for example with JavascriptModules resolvign the path "//" improperly.

Caused by https://review.typo3.org/c/Packages/TYPO3.CMS/+/84383 due to the removal of "handleRootPackage" in the loop of extensions.

Can be reproduced with any TYPO3 extension installation like https://github.com/eliashaeussler/typo3-warming

Happes in v12 and v13

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #103898: Existing "_assets" subdirectories not being a symlink prevents installationClosed2024-05-24

Actions
Actions
Copy link
 #1

Updated by Garvin Hicking 4 months ago

  • Related to Bug #103898: Existing "_assets" subdirectories not being a symlink prevents installation added
Actions
Copy link
 #2

Updated by Gerrit Code Review 4 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85212

Actions
Copy link
 #3

Updated by Gerrit Code Review 4 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85212

Actions
Copy link
 #4

Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85212

Actions
Copy link
 #5

Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85198

Actions
Copy link
 #6

Updated by Garvin Hicking 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Benjamin Franzke 4 months ago

Just want to mention that this also affected TypoScript loaded from v13 site-sets, because packagePath ended up as "/var/www/html///":

object(TYPO3\CMS\Core\Package\Package)#294 (8) {
  ["partOfFactoryDefault":protected]=>
  bool(false)
  ["partOfMinimalUsableSystem":protected]=>
  bool(false)
  ["serviceProvider":protected]=>
  uninitialized(?string)
  ["packageKey":protected]=>
  string(15) "theme_portfolio" 
  ["packagePath":protected]=>
  string(16) "/var/www/html///"

…which then got ignored by the TypoScript parser once it was composed into "/var/www/html///Configuration/Sets/ThemePortfolio"

Good news is: The (already merged) patch solves this case as well :)

Actions
Copy link
 #8

Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF