TYPO3 Core

Reproduced this via:

1. Create a page "Invisible"
2. Create a content element of type "Header Only". Can be empty.
3. Hide that content element.
4. Create a page "Linked".
5. Create a content element of type "Header Only". For the field "Link [header_link]" open the link browser, go to page "Invisible", select hidden content element there.
6. Go to linkvalidator, validate the page "Linked"
7. The resulting output will show the error from the screenshot, the broken link will lead to having the page UID set as the content element UID

I've tried to debug this for more than an hour, and the code is very hard for me to read.

https://github.com/TYPO3/typo3/blob/main/typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php#L370 seems to be missing an array key like

            $results[$type][$table . ':' . $field . ':' . $idRecord . ':' . $reference['tokenID']]['pageAndAnchor'] = $record['pid'];

but I can't see how to construct this to only do that in case of a "t3://page?uid=4711#0815" link.

In https://github.com/TYPO3/typo3/blob/main/typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php#L95 there's already some 't3://' parsing involved, unsure if there a specific key needs to be set.

Ultimately, in https://github.com/TYPO3/typo3/blob/main/typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php#L211 there's:

                if (!empty($entryValue['pageAndAnchor'] ?? '')) {
                    // Page with anchor, e.g. 18#1580
                    $url = $entryValue['pageAndAnchor'];
                } else {
                    $url = $entryValue['substr']['tokenValue'];
                }

where the proper URL would need to be referenced. As noted this "pageAndAnchor" would be a key that could be utilized. Otherwize the `$url` variable here could also be set to something from `$entryValue` but I don't really get where all this is coming from and to.

Jsut leaving this here in case it finds someone with expertise or more willpower than me.

To summarize: The problem only occurs if a link to a content element is used in header_link, not in bodytext?

I can reproduce this.

I think I should be able to provide a patch. Here is some more information:

About debugging: you ideally debug LinkAnalyzer::analyzeRecord when checking links, e.g. by putting a breakpoint there with condition, e.g. $table == 'tt_content' or putting the breakpoint on line 337.

I also checked the database first because I wanted to make sure the problem is in the checking:

select url,table_name,field from tx_linkvalidator_link where record_pid=663;
+-------------+------------+-------------+
| url         | table_name | field       |
+-------------+------------+-------------+
| 101999      | tt_content | header_link |
| 664#c101999 | tt_content | bodytext    |
+-------------+------------+-------------+

This confirms: It is already wrong when written to the DB, the URL should be the same.

The problem seems to be that for bodytext TypolinkTagSoftReferenceParser is used and for header_link TypolinkSoftReferenceParser. Both (correctly) return the same result, but in line 337 of LinkAnalyzer there is an if switch:

if ($softReferenceParser->getParserKey() === 'typolink_tag') {
  $this->analyzeTypoLinks($parserResult, $results, $htmlParser, $record, $field, $table);
} else {
  $this->analyzeLinks($parserResult, $results, $record, $field, $table);
}

So for header_link analyzeLinks is called and for bodytext analyzeTypoLinks - even though it is also a typolink. Where in the one case pageAndAnchor is written and in the other not.

And you can see in line 214 what happens:

if (!empty($entryValue['pageAndAnchor'] ?? '')) {
  // Page with anchor, e.g. 18#1580
  $url = $entryValue['pageAndAnchor'];
} else {
  $url = $entryValue['substr']['tokenValue'];
}

I did not thoroughly debug that part, but pretty confident that is the problem.

This code has not been changed much for years. I will also check other versions 11 and 12 to check if new problem or already existed.

I could also reproduce this in v11 and v12.

We just came across this issue as we show broken links with an dashboard widget. The editors don't usually use the backend module.

Please ignore my previous comment. It seems to be correct that the link parser returns 2 items for a link with anchor. (However the comment may still be useful for understanding the code).

I have fixed the behaviour in "brofix" which uses similar code see https://github.com/sypets/brofix/pull/404/files

Linkvalidator handles the results from TypolinkTagSoftreferenceParser and TypolinkSoftReferenceParser difference, for the former analyzeTypoLinks is called and for the latter analyzeLinks.

analyzeTypoLinks handles the duplicate entries for one link for the specific usecase page with anchor, analyzeLinks does not.

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86875

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86875

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86875

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86875

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86875

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87004