Bug #104851
closedError upon localization configuration via TsConfig
100%
Description
i wanted to try TYPO3 13.2.1 and test some TsConfig options.
Case:
I have 2 languages defined. It doesnt matter what the translation behavior is, the error appears on all 3 modes. Using either of those 2 settings, produces the error.
mod.web_layout { localization { enableCopy = 0 enableTranslate = 0 } }
The error that appears (503):
Core: Exception handler (WEB): Uncaught TYPO3 Exception: Cannot assign string to property TYPO3\CMS\Backend\View\Drawing\DrawingConfiguration::$allowTranslateModeForTranslations of type bool | TypeError thrown in file /myPath/vendor/typo3/cms-backend/Classes/View/Drawing/DrawingConfiguration.php in line 99. Requested URL: https://example.com/typo3/module/web/layout?token=--AnonymizedToken--&id=1
Solution:
Theoritically:
Here https://github.com/TYPO3/typo3/blob/main/typo3/sysext/backend/Classes/View/Drawing/DrawingConfiguration.php#L73 the allowTranslateModeForTranslations
variable has been set to bool, but the https://github.com/TYPO3/typo3/blob/main/typo3/sysext/backend/Classes/View/Drawing/DrawingConfiguration.php#L99C123-L100C69 return a string with the value 0
. The same happens with the allowCopyModeForTranslations
variable
Maybe typecast the array value
$obj->allowTranslateModeForTranslations = (bool)$pageTsConfig['mod.']['web_layout.']['localization.']['enableTranslate'] ?? true;
$obj->allowCopyModeForTranslations = (bool)$pageTsConfig['mod.']['web_layout.']['localization.']['enableCopy'] ?? true;
but i don't know if adding a normal string as value via tsconfig will cause a problem for not properly typecasting. Something like that:
mod.web_layout { localization { enableCopy = a string value enableTranslate = some other string value } }
Files
Updated by Benjamin Franzke 24 days ago
- Related to Task #103345: Fluid-based Page module has some naming issues added
Updated by Benjamin Franzke 24 days ago
- Status changed from New to Accepted
- Assignee set to Benni Mack
Updated by Gerrit Code Review 24 days ago
- Status changed from Accepted to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86448
Updated by Benni Mack 24 days ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 79d5daa6911b35e9222d2a70c0e486d48891596e.