Project

General

Profile

Actions

Bug #104858

closed

SiteSettings->get() does return values for nested arrays in subproperties

Added by Benjamin Franzke about 2 months ago. Updated 16 days ago.

Status:
Closed
Priority:
Should have
Category:
Site Handling, Site Sets & Routing
Target version:
Start date:
2024-09-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

A setting defined via Configuration/Sets/Set1/settings.definitions.yaml that contains at least one dot in the settings key

settings:
  foo.bar:
    type: stringlist
    default: ['a', 'b']
    label: FooBar

Can not be obtained by $settings->get('foo.bar'), because array-flattening does only allow access to 'foo.bar.0' and 'foo.bar.1', but not to the array 'foo.bar'.

This is because this value is serialized as

foo:
  bar:
    - a
    - b

The SiteSettings object should maintain an access for explicitly defined keys, and provide the values as well.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #104945: SiteSettings cache is created over and over again, with every requestClosedBenjamin Franzke2024-09-12

Actions
Actions #1

Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85924

Actions #2

Updated by Gerrit Code Review about 2 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85924

Actions #3

Updated by Gerrit Code Review about 2 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85924

Actions #4

Updated by Benjamin Franzke about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benjamin Franzke about 2 months ago

  • Related to Bug #104945: SiteSettings cache is created over and over again, with every request added
Actions #6

Updated by Benni Mack 16 days ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF