Bug #104900: Invalid yaml in site settings should give some kind of warning - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #104900

closed

Invalid yaml in site settings should give some kind of warning

Added by Lina Wolf about 2 months ago. Updated 16 days ago.

Status:

Closed

Priority:

Should have

Assignee:

Benjamin Franzke

Category:

Backend User Interface

Target version:

Start date:

2024-09-11

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

If I accidently break the settings.definition.yaml with invalid yaml like so:

categories !!!???
  BlogExample:
    label: 'Blog Example'
  BlogExample.templates:
    label: 'Templates'
    parent: BlogExample

There is no warning displayed in the new Sites > Settings module, the settings just disappear, including dependant sets.

I would suggest to display some kind of warning in such a case, Expecially in local application context.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Stefan Bürk about 2 months ago

settings.definition.yaml is a code thing and should be covered by CI already.

Literally, you could use the symfony yaml linter (vendor/bin/yaml-lint) in composer mode for that,
however that does not count for legacy installs.

See https://review.typo3.org/c/Packages/TYPO3.CMS/+/84438 which introduces the command to the TYPO3 binary.

Actions

Copy link

Updated by Benjamin Franzke 28 days ago

Related to Task #103558: Add warning to site module in case set dependencies are broken added

Actions

Copy link

Updated by Benjamin Franzke 28 days ago

Assignee set to Benjamin Franzke

Actions

Copy link

Updated by Gerrit Code Review 27 days ago

Status changed from New to Under Review

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86392

Actions

Copy link

Updated by Gerrit Code Review 27 days ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86392

Actions

Copy link

Updated by Gerrit Code Review 27 days ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86392

Actions

Copy link

Updated by Benjamin Franzke 24 days ago

Has duplicate Bug #105210: Site set isn't loaded or gets removed if the setttings.definition.yaml is somehow malformed added

Actions

Copy link

Updated by Gerrit Code Review 24 days ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86392

Actions

Copy link

Updated by Gerrit Code Review 24 days ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86392

Actions

Copy link

#10

Updated by Gerrit Code Review 24 days ago

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86392

Actions

Copy link

#11