TYPO3 Core

Thanks for the feedback. If you are able to provide a smaller, isolated example at some point, we might be able to help. tt_products is too big and loaded with dependencies we cannot properly debug within reasonable time.

I guess we could here add an early check if the expolded array does not contain any elements:

https://github.com/TYPO3/typo3/blob/35c9b96336d8644b52ef9045969a47475f559da5/typo3/sysext/backend/Classes/Form/Container/FullRecordContainer.php#L44

        $fieldsArray = GeneralUtility::trimExplode(',', $itemList, true);
// add here a $fieldsArray === [] check and return early - or ensure that handling below is guarded properly
        // Streamline the fields array
        // First, make sure there is always a --div-- definition for the first element
        if (!str_starts_with($fieldsArray[0], '--div--')) {
            array_unshift($fieldsArray, '--div--;LLL:EXT:core/Resources/Private/Language/Form/locallang_tabs.xlf:general');

Thanks for reportng this. Not sure how this occured or can be reproduced, but guarding that make sense I guess.

Unsure about this. The rest of the method really expects that fieldArray contains information. The method returns something vital which an 'early return' IMO would break.

This kind of sounds to me like a TCA misconfiguration issue. I think we need an EXT:styleguide reproducible example for it first.

Garvin Hicking wrote in #note-5:

Unsure about this. The rest of the method really expects that fieldArray contains information. The method returns something vital which an 'early return' IMO would break.

This kind of sounds to me like a TCA misconfiguration issue. I think we need an EXT:styleguide reproducible example for it first.

ack. should not investigate such things laying tired on hells floor - being there now again ;)

@Franz Holzinger

Could you please fully dump / save the content of $this->data before the `if (!str_starts_with(....` when $fieldArray is an empty array ?

Something like

$fieldsArray = GeneralUtility::trimExplode(',', $itemList, true);

//--------------------------------------
file_put_contents(
  \TYPO3\CMS\Core\Core\Environment::getVarPath() . '/empty-field-array-in-full-record-container.json',
  \json_encode($this->data, JSON_PRETTY_PRINT),
);
//--------------------------------------

if (!str_starts_with($fieldsArray[0], '--div--')) {

at this place: https://github.com/TYPO3/typo3/blob/35c9b96336d8644b52ef9045969a47475f559da5/typo3/sysext/backend/Classes/Form/Container/FullRecordContainer.php#L44

Hey Franz,

you can actually fix this by using this configuration in your parent table when defining the type=inline:

'appearance' => [
        'collapseAll' => 1,
    ]

if you don't have any visible fields in your child table, then collapseAll should be sufficient

@Benni Mack :

I have tried it out:

'article_uid' => [
        'exclude' => 1,
        'label' => 'LLL:EXT:' . $extensionKey . $languageSubpath . 'locallang_db.xlf:' . $table . '.article_uid',
        'config' => [
            'type' => 'inline',
            'appearance' => [
                    'collapseAll' => true,
                    // 'newRecordLinkAddTitle' => true,
                    // 'useCombination' => true,
                ],
            'foreign_table' => 'tt_products_products_mm_articles',
            'foreign_field' => 'uid_local',
            'foreign_sortby' => 'sorting',
            'foreign_label' => 'uid_foreign',
            'foreign_selector' => 'uid_foreign',
            'foreign_unique' => 'uid_foreign',
            'maxitems' => 1000,
            'default' => 0,
        ],
    ],

No difference. There is still the same error message.

This commit fixes this issue.

tt_products TCA/tt_products_products_mm_articles.php

Thanks, I suggest closing this ticket now, and actually adding some information to docs.typo3.org that showitem should include at least one field. OK?

It would be more helpful if TYPO3 could warn about this (log file or somewhere else) or even throw an exception in such a case like this one.

Patch set 1 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86862