Feature #105007
closed
Indexed Search - removed searchSkipExtendToSubpagesChecking can't be migrated
100%
Description
The option searchSkipExtendToSubpagesChecking was removed in #97530. This decision was a nightmare for our very big typo3 sites. With 5000+ pages this removed option has serious performance penalties. Every search request will now create a page tree with many database queries. One request can take up to 10 seconds. The migration path described here is just: "If you still encounter using indexed search related to extendToSubpages it is recommended to extend Indexed Search queries with custom hooks to manipulate the search query."
But the hook is not equipped to replace the old functionality. In v12 it was not given the query builder to give fine granular control and in v13 the hook was removed completly in #102937. What do we now? We need a hook to manipulate the search query for big typo3 sites.
Updated by Georg Ringer 2 months ago
- Related to Task #97530: Remove Indexed Search option searchSkipExtendToSubpagesChecking added
Updated by Georg Ringer 2 months ago
- Related to Task #102937: Remove pi1_hooks in Indexed Search added
Updated by Georg Ringer 2 months ago
hey!
thanks for your issue! can you suggest places for events which would make sense for you?
Updated by B. Kausch 2 months ago
ยท Edited
Well, my suggestion would be these spots:
https://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/main/entry/typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php#L548
https://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/main/entry/typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php#L1008
It is before the query is executed and if the hook would expose the QueryBuilder instance every integrator would have the most freedom to change the search behavior. You combine that with an rootPidList=-1 to disable the very extensive building of the page tree this hook could meet any needs.
Updated by Benni Mack about 2 months ago
The two changes we need to look at:
- https://review.typo3.org/c/Packages/TYPO3.CMS/+/74377
- https://review.typo3.org/c/Packages/TYPO3.CMS/+/82653
Updated by Gerrit Code Review about 1 month ago
- Status changed from Accepted to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Gerrit Code Review about 1 month ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Gerrit Code Review about 1 month ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Gerrit Code Review about 1 month ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Gerrit Code Review about 1 month ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Gerrit Code Review about 1 month ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Gerrit Code Review about 1 month ago
Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Gerrit Code Review about 1 month ago
Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Benni Mack about 1 month ago
- Target version changed from 13 LTS to Candidate for Major Version
Updated by Gerrit Code Review about 1 month ago
Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Gerrit Code Review about 1 month ago
Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Gerrit Code Review about 1 month ago
Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Gerrit Code Review about 1 month ago
Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Gerrit Code Review about 1 month ago
Patch set 13 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Gerrit Code Review about 1 month ago
Patch set 14 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86593
Updated by Gerrit Code Review about 1 month ago
Patch set 1 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86616
Updated by Oliver Bartsch about 1 month ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a331b40ba33ee0448fd1c5852a83e4d756e82818.
Updated by Gerrit Code Review about 1 month ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86616
Updated by Oliver Bartsch about 1 month ago
- Status changed from Under Review to Resolved
Applied in changeset 4d48fc427bcbe67e46c63c2415a492de232bd771.