Bug #105254: PHP Warning: Undefined array key "removeTags." in typo3/cms-core/Classes/Html/HtmlParser.php - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #105254

closed

PHP Warning: Undefined array key "removeTags." in typo3/cms-core/Classes/Html/HtmlParser.php

Added by Georg Tiefenbrunn 22 days ago. Updated 16 days ago.

Status:

Closed

Priority:

Must have

Assignee:

Garvin Hicking

Category:

RTE (rtehtmlarea + ckeditor)

Target version:

Start date:

2024-10-09

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

trivial

Is Regression:

Yes

Sprint Focus:

Description

https://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/6edf734060d4329c7eb6f5c5a50cfe9d41cb2d34 introduces a regression.

If removeTags is a string (e.g. set by TSconfig or TypoScript lib.parseFunc), $TSconfig['removeTags.'] (with trailing dot) might be undefined (https://github.com/TYPO3/typo3/blob/778ef12acd546ff7fb44bd308f3dca7e9a945126/typo3/sysext/core/Classes/Html/HtmlParser.php#L978).

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Georg Tiefenbrunn 22 days ago

Related to Bug #104839: CKEditor YAML processing.HTMLparser_db.removeTags uses wrong syntax added

Actions

Copy link

Updated by Garvin Hicking 22 days ago

Category set to RTE (rtehtmlarea + ckeditor)
Status changed from New to Accepted
Assignee set to Garvin Hicking
Priority changed from Should have to Must have

Thanks for the headsup. Will provide a patch tomorrow.

Actions

Copy link

Updated by Gerrit Code Review 21 days ago

Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86543

Actions

Copy link

Updated by Gerrit Code Review 21 days ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86543

Actions

Copy link

Updated by Gerrit Code Review 21 days ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86543

Actions

Copy link

Updated by Gerrit Code Review 21 days ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86543

Actions

Copy link

Updated by Gerrit Code Review 21 days ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86543

Actions

Copy link

Updated by Gerrit Code Review 21 days ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86543

Actions

Copy link

Updated by Georg Tiefenbrunn 20 days ago

Quick workaround if you're using TypoScript like lib.parseFunc.nonTypoTagStdWrap.HTMLparser.removeTags = font

lib.parseFunc {
  # Allow the tag to be removed
  allowTags := addToList(font)
  nonTypoTagStdWrap.HTMLparser {
    # Disable 'removeTags' to prevent Undefined array key "removeTags." 
#    removeTags = font
    tags {
      # Remove the tag using the logic from HtmlParser.php
      font {
        allowedAttribs = 0
        rmTagIfNoAttrib = 1
      }
    }
  }
}

Actions

Copy link

#10

Updated by Gerrit Code Review 20 days ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86479

Actions

Copy link

#11