Task #105365
closedTCA: FormEngineValidation.processValue() does not always use declared return type
100%
Description
FormEngineValidation.processValue
with argument 'integer'
actually returns number
instead of string
:
FormEngineValidation.processValue = function(…): string {}
FormEngineValidation.processValue('integer', …) {
return … someValue as number
}
Call-chain - the return type of these functions is declared as string
:
FormEngineValidation.updateInputField = function(…): void {
(someField as HTMLInputElement).value: string = FormEngineValidation.processByEvals(…) as number
}
FormEngineValidation.processByEvals = function(…): string {
return … FormEngineValidation.processValue(…) as number
}
FormEngineValidation.processValue = function(…): string {
return … someValue as number
}
Updated by Ayke Halder 12 days ago
- Related to Task #105366: Introduce type for @typo3/backend/form-engine-validation added
Updated by Gerrit Code Review 12 days ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86660
Updated by Gerrit Code Review 11 days ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86660
Updated by Gerrit Code Review 2 days ago
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86822
Updated by Gerrit Code Review 2 days ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86822
Updated by Gerrit Code Review 2 days ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86822
Updated by Gerrit Code Review 1 day ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86822
Updated by Benjamin Franzke 1 day ago
- Tracker changed from Bug to Task
- TYPO3 Version changed from 12 to 13
Updated by Gerrit Code Review 1 day ago
Patch set 1 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86833
Updated by Anonymous 1 day ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset d5ef710533722b4d893e8cb20265139ecd979c85.