Project

General

Profile

Actions

Task #105365

closed

TCA: FormEngineValidation.processValue() does not always use declared return type

Added by Ayke Halder 12 days ago. Updated 1 day ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Backend JavaScript
Target version:
-
Start date:
2024-10-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

FormEngineValidation.processValue with argument 'integer' actually returns number instead of string:

FormEngineValidation.processValue = function(): string {}

FormEngineValidation.processValue('integer', ) {
  return  someValue as number
}

Call-chain - the return type of these functions is declared as string:

FormEngineValidation.updateInputField = function(): void {
  (someField as HTMLInputElement).value: string = FormEngineValidation.processByEvals() as number
}

FormEngineValidation.processByEvals = function(): string {
  return  FormEngineValidation.processValue() as number
}

FormEngineValidation.processValue = function(): string {
  return  someValue as number
}

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #105366: Introduce type for @typo3/backend/form-engine-validationResolved2024-10-19

Actions
Actions #1

Updated by Ayke Halder 12 days ago

  • Related to Task #105366: Introduce type for @typo3/backend/form-engine-validation added
Actions #2

Updated by Gerrit Code Review 12 days ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86660

Actions #3

Updated by Gerrit Code Review 11 days ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86660

Actions #4

Updated by Gerrit Code Review 2 days ago

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86822

Actions #5

Updated by Gerrit Code Review 2 days ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86822

Actions #6

Updated by Gerrit Code Review 2 days ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86822

Actions #7

Updated by Gerrit Code Review 1 day ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86822

Actions #8

Updated by Benjamin Franzke 1 day ago

  • Tracker changed from Bug to Task
  • TYPO3 Version changed from 12 to 13
Actions #9

Updated by Gerrit Code Review 1 day ago

Patch set 1 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86833

Actions #10

Updated by Anonymous 1 day ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF