Bug #11794: If website root is active, searching for links does not work - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Actions

Copy link

Bug #11794

closed

If website root is active, searching for links does not work

Added by Chris topher almost 14 years ago. Updated almost 11 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Pierre Boivin

Category:

Linkvalidator

Target version:

Start date:

2010-12-30

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

When the globe (page id = 0) is active, searching for broken links does not display any result.

This was working once - at least there is a picture in the manual showing the working module while the rootpage is activated.

Either display a hint to choose a page first (as the page module does) or make it work again (would be even better).

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Pierre Boivin almost 14 years ago

Assignee set to Pierre Boivin

Actions

Copy link

Updated by Pierre Boivin almost 14 years ago

Status changed from New to Resolved

Corrected

Actions

Copy link

Updated by Chris topher almost 14 years ago

Status changed from Resolved to Needs Feedback

Hmm, does not work for me. :-(

What should happen:
When the rootpage is activated, the statistics table and the table showing the broken links should work just as for every other page. That means, depending on the search_level set, they should display the number of results (in the stats table) and the broken links for the checked options (in the second table).

But currently when I activate the rootpage, the statistics table always displays zero results and there also are none for the broken links table.

Actions

Copy link

Updated by Pierre Boivin almost 14 years ago

I just roll back my solution.

Seems like, it doesn't work anyway for Depth selection.

The problem is "t3lib_tsfeBeUserAuth::extGetTreeList" that is use and doesn't support page id "0".

I think we should display a message instead.

Actions

Copy link

Updated by Pierre Boivin almost 14 years ago

I added a warning message in case the rootpage (zero) is activated.

Actions

Copy link

Updated by Chris topher almost 14 years ago

Much better than before!

But it has the side-effect that you can no longer check broken pages for the whole tree on one screen by selecting the globe and some search depth. If you have e.g. 15 subpages under the globe you now have to check each of them seperately.

Looking at usability it would be better, if it worked again with id=0; do you think you could try to fix it that way?

Actions

Copy link

Updated by Pierre Boivin almost 14 years ago

Assignee deleted (~~Pierre Boivin~~)

I can try but probably not this week.

As I said, we will have to use another function than "t3lib_tsfeBeUserAuth::extGetTreeList" because it doesn't support id=0

Actions

Copy link

Updated by Chris topher almost 14 years ago

% Done changed from 0 to 50

Actions

Copy link

Updated by Pierre Boivin almost 14 years ago

Assignee set to Pierre Boivin

Actions

Copy link

#10

Updated by Pierre Boivin almost 14 years ago

Assignee deleted (~~Pierre Boivin~~)

Corrected.

Those modifications needs test before closing the issue.

Actions

Copy link

#11

Updated by Pierre Boivin almost 14 years ago

Status changed from Needs Feedback to Resolved
% Done changed from 50 to 100

Applied in changeset r41875.

Actions

Copy link

#12

Updated by Chris topher almost 14 years ago

Status changed from Resolved to Under Review

Wow, thank you for fixing this a second time!
I think when I wrote the bug report I should immediatelly have said more clearly, which solution I really wanted - sorry for the inconveniences!

I will review it today!

Actions

Copy link

#13

Updated by Chris topher almost 14 years ago

Status changed from Under Review to Needs Feedback

The layout of the backend interface is working correctly.

But the logic to get $pageList does not work correctly:

If I have a page with another id than 0 selected, I get the same broken links like before.
With pid=0 I get no results. Reason seems to be that pageList in that case stays empty.

Actions

Copy link

#14

Updated by Pierre Boivin almost 14 years ago

I can't reproduce this bug. It works here for me.

Actions

Copy link

#15

Updated by Pierre Boivin almost 14 years ago

Assignee set to Pierre Boivin

Actions

Copy link

#16

Updated by Pierre Boivin almost 14 years ago

Status changed from Needs Feedback to Under Review

You can test again. Probably it was caused by shortcut pages or other page type.

Actions

Copy link

#17

Updated by Pierre Boivin almost 14 years ago

Assignee deleted (~~Pierre Boivin~~)

Actions

Copy link

#18

Updated by Philipp Gampe almost 14 years ago

works for me ... make sure to select the the amount of subpages to search for !!! current page will not show any result ;)

Actions

Copy link

#19

Updated by Pierre Boivin almost 14 years ago

Assignee set to Pierre Boivin

Actions

Copy link

#20

Updated by Pierre Boivin almost 14 years ago

isn't already like that ?

Actions

Copy link

#21

Updated by Chris topher almost 14 years ago

As far as I can tell, Pierre's patch is working. Sure you have to set the level of pages to search to something different than "this page", but that is only logical.

Btw @ Pierre: Good guess with the shortcut pages - that was the problem. :-)

I'd say this one is solved.

Actions

Copy link

#22