TYPO3 Core

That should work if you can implement the whole interface in the abstract class already. Subclasses from an abstract class which implements an interface automatically "implement the interface" too, AFAIK.

So just give it a try!

As soon as the interface is there, the loop that goes through all hook objects should check if the $hookObj implements the interface and throw an Exception if not.

Thanks for taking a look at it!

Hi Christopher,

nice work. Some things are still not ok:

1) class.tx_linkvalidator_tasks_validate.php is still missing to declare one variable $this->configuration.

2) the members which are accessed from external class (task) need to be all "public" (e.g. $depth, $page, etc). Else you get an error when saving a new task

=> make sure the scheduler task still work after your changes!

while you are at it:

3) please rename the variables and fieldnames:
- emailonbrokenlinkonly => emailOnBrokenLinkOnly
- emailfile => emailTemplateFile

4) add some error checking in execut() and throw Exceptions if there are some bogus conditions:

a) if !file_exists ($file=t3lib_div::getFileAbsFileName($this->emailfile));
b) if count($parseObj->error) > 0
c) if t3lib_div::validEmail($this->email)

The Exceptions could contain the relevant information what was wrong so that the user knows which field need to be corrected first.

Thanks!!! Nice work!

Ernesto Baschny wrote:

a) if !file_exists ($file=t3lib_div::getFileAbsFileName($this->emailfile));

this check should also be tx_linkvalidator_tasks_ValidateAdditionalFieldProvider

Christopher wrote:

Checked and tested. Everything seems still to be working, I only changed some texts.

If no one else find something wrong in this bug, ill comit it to the trunk in about 3 hours

sorry forgot to erase path in the patch

I not sure if it was this patch, but I strongly guess so.

In latest trunk (typo3 & linkvalidator) I don't get valid links any more for broken internal links:

http:///index.php?id=82

it misses both domain and rootline (I would prefer to get FE-links including transformation by realurl or cooluri).

Best regards
Phil