Feature #12447
closed
Clearly separate Checks from Report in module
Added by Patrick Gaumond almost 14 years ago. Updated almost 11 years ago.
0%
Description
Here's a screenshot of a new UI for Linkvalidator's module. The idea being to clearly separate both functions:
1. Broken links Report
2. Check links (This whole section can be hidden by TS)
Files
| Linkvalidator_V2.jpg (157 KB) Linkvalidator_V2.jpg | Version 2 with tabs : Report - Check links | Patrick Gaumond, 2011-01-21 20:36 | |
| 12447.diff (12.6 KB) 12447.diff | Michael Miousse, 2011-01-24 15:21 | ||
| linkvalidator-chrome.png (110 KB) linkvalidator-chrome.png | this is how it looks in chrome | Philipp Gampe, 2011-01-24 22:53 | |
| 12447.diff (12.2 KB) 12447.diff | now with correct paths ;) | Philipp Gampe, 2011-01-24 22:53 | |
| 12447_v2.diff (14.3 KB) 12447_v2.diff | Steffen Kamper, 2011-01-25 11:58 | ||
| 12447_v3.patch (14.3 KB) 12447_v3.patch | Chris topher, 2011-01-25 15:41 | ||
| 12447_v4.diff (16.9 KB) 12447_v4.diff | Michael Miousse, 2011-01-25 16:18 | ||
| 12447_v5.patch (17.2 KB) 12447_v5.patch | Chris topher, 2011-01-25 16:52 | ||
| 12447_v6.patch (17.2 KB) 12447_v6.patch | Chris topher, 2011-01-25 17:19 |
Updated by Patrick Gaumond almost 14 years ago
- File Linkvalidator_V2.jpg Linkvalidator_V2.jpg added
Here's an even better solution that use tabs so repetition is gone for the users !
"Report" is default(first) "Check link" tab can be hidden through TSconfig.
Updated by Patrick Gaumond almost 14 years ago
- File deleted (
Linkvalidator-newUI.jpg)
Updated by Philipp Gampe almost 14 years ago
looks good :)
I will check latest status tomorrow ... sorry for not doing it tonight ;(
Updated by Ernesto Baschny almost 14 years ago
What will the "Check links" tab do? To me it sounds like it triggers an "Action" and this isn't something a Tab should do just by selecting it.
I like it as a "button", and I feel that the "Refresh" button is superfluous.
In my opinion the "Check links" button must provide some kind of feedback of what its doing, and maybe an alert box telling the user what's going to happen before starting (because depending on the amount of external links, it could take a while!
A "Progress-Bar" (extJS) would also be a neat addition while checking the links.
But I fear this won't be possible until the release, RC1 status (tonight) is not something where we can still come up with a totally new UI. We should now only fix the last bugs.
New UI etc could be done with 4.6 goal in mind.
Updated by Chris topher almost 14 years ago
Ernesto Baschny wrote:
But I fear this won't be possible until the release, RC1 status (tonight) is not something where we can still come up with a totally new UI. We should now only fix the last bugs.
New UI etc could be done with 4.6 goal in mind.
Good to know that there is some time to get this done.
Updated by Michael Miousse almost 14 years ago
- File 12447.diff 12447.diff added
I have worked overweekend to bring the "tabbed" Linkvsalidator to reality.
There' still CSS work to be done and some more Browser testing.
The work has been done with this in mind: "The less change to the pre-Friday code (RC1), the better.
So please check the patch and test it as soon as possible in order to make changes if necessary
Updated by Patrick Gaumond almost 14 years ago
While the patch is not official, I'm adding notes here:
1. Normal behaviour: You always land on the Report tab. That's on purpose.
2. BUG: If you set checkboxes in "Check Links" then execute, External links are always checked. (Dropdown menu for depth is ok).
3. BUG: Fix CSS
4. FEATURE needed: Draw a "In progress" (spinner) while checking links.
Updated by Philipp Gampe almost 14 years ago
- File linkvalidator-chrome.png linkvalidator-chrome.png added
- File 12447.diff 12447.diff added
looks almost ok ... it really needs padding to top and left !!!
This is how it looks in Chromium
Updated by Steffen Kamper almost 14 years ago
- File 12447_v2.diff 12447_v2.diff added
Here is an updated patch with CGL and other cleanup, also dynamic height of tab panel and padding added. Please commit this one today for the final merge.
Updated by Chris topher almost 14 years ago
- Two warnings in the background:
Warning: filemtime(): stat failed for /t3lib/js/wxtjs/ux/Ext.ux.FitToParent.js in \t3lib\class.t3lib_compressor.php on line 339
Warning: filesize(): stat failed for t3lib/js/wxtjs/ux/Ext.ux.FitToParent.js in \t3lib\class.t3lib_compressor.php on line 339 - Checking for broken links always checks all types of links currently. Either remove checkboxes there or better make button take care for selected options.
Updated by Michael Miousse almost 14 years ago
Christopher wrote:
First review:
- Two warnings in the background:
Warning: filemtime(): stat failed for /t3lib/js/wxtjs/ux/Ext.ux.FitToParent.js in \t3lib\class.t3lib_compressor.php on line 339
Warning: filesize(): stat failed for t3lib/js/wxtjs/ux/Ext.ux.FitToParent.js in \t3lib\class.t3lib_compressor.php on line 339- Checking for broken links always checks all types of links currently. Either remove checkboxes there or better make button take care for selected options.
im on the check all type and i found the fix could you check for the warning?
Updated by Chris topher almost 14 years ago
- File 12447_v3.patch 12447_v3.patch added
Michael Miousse wrote:
im on the check all type and i found the fix could you check for the warning?
Done. Was a typo. If you already made bigger changes: modfuncreport.php, line 610: Backpath must not have "wxtjs" in the path, but "extjs".
Updated by Michael Miousse almost 14 years ago
- File 12447_v4.diff 12447_v4.diff added
Christopher wrote:
Michael Miousse wrote:
im on the check all type and i found the fix could you check for the warning?
Done. Was a typo. If you already made bigger changes: modfuncreport.php, line 610: Backpath must not have "wxtjs" in the path, but "extjs".
here is v4 with check option corrected and wxtjs corrected
Updated by Chris topher almost 14 years ago
- File 12447_v5.patch 12447_v5.patch added
- Slightly improved CSS
- searchLevel added in modfuncreport after line 151
- class tx_linkvalidator_Processor line 121: count > 0
- Some clean up
Updated by Chris topher almost 14 years ago
- File 12447_v6.patch 12447_v6.patch added
- h4 headlines.
- Checkboxes on the right are too low
- No scrolling!
- Option name "showUpdateButton" is misleading now
- Update manual
Updated by Michael Miousse almost 14 years ago
- Status changed from Needs Feedback to Resolved
Committed revision 42587.
Updated by Chris topher over 12 years ago
- Status changed from Resolved to Closed
Updated by Michael Stucki almost 11 years ago
- Project changed from 1510 to TYPO3 Core
- Category changed from Linkvalidator to Linkvalidator