Project

General

Profile

Actions

Bug #14146

closed

Thumbnails in Element Browser are only displayed if fileSuffix is lowercase

Added by Mathias Schreiber over 20 years ago. Updated over 16 years ago.

Status:
Closed
Priority:
Could have
Assignee:
Category:
Backend API
Target version:
-
Start date:
2004-05-07
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.1
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

This bug s only present with "typo3/browse_links.php"

(issue imported from #M65)


Files

0000065.patch (770 Bytes) 0000065.patch Administrator Admin, 2007-09-18 20:48

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #17504: No thumbnails generated for jpg and pngClosedChristian Kuhn2007-08-08

Actions
Actions #1

Updated by Mathias Schreiber over 20 years ago

Change:
/t3lib/class.t3lib_div.php
Line 645
function inList($in_list,$item) {
#return strstr(','.$in_list.',', ','.$item.',');
return strstr(','.strtolower($in_list).',', ','.strtolower($item).',');
}

Except this behaviour is wanted.
You can fix it by adding JPG to $TYPO3_CONF_VARS["GFX"]["imagefile_ext"] but I think this might be more intuitive to just change the function.
Any drawbacks involved?

Actions #2

Updated by Kasper Skårhøj over 20 years ago

The requirements o fthis function is to do a binary safe in-list comparison. If we change that we will damage TYPO3 in a thousand places.

Make sure the inputs are strtolower()'ed before calling the funciton.

Actions #3

Updated by Mathias Schreiber over 20 years ago

then we would change it in brose_links.php, right?

Actions #4

Updated by Daniel Poetzinger over 20 years ago

To the Tumbnails:

If there are spaces in filename the Tumbnail generator looks for a file rawurlencode($filename) or something linke that, which means that the file is not found in the filesystem.

The error appears if a plugin "manually" adds his filename in a table as for example fe_user (picture) and the filename is f.e. "bild 199.jpg"...

(I know replacing spaces with "_" by the plugin would solve this, but I dont see the necessary to make urlencode for the filename??)

Actions #5

Updated by Oliver Hader about 17 years ago

Wow. This is still present in TYPO3 4.2.0-alpha1... ;-)
I finally added the small patch to solve this and to show thumbnails of files like "something.GIF".

Actions #6

Updated by Oliver Hader about 17 years ago

Committed to SVN:
  • TYPO3_4-1 (rev. 2513)
  • Trunk (rev. 2514)
Actions

Also available in: Atom PDF