TYPO3 Core

According to [1] there were no changes in class.tslib_fe.php between 3.6.0 and 3.6.1.

Can you please recheck?

[1] http://cvs.sourceforge.net/viewcvs.py/typo3/TYPO3core/typo3/sysext/cms/tslib/class.tslib_fe.php?only_with_tag=TYPO3_3-6-0

? solved but not tested?
I wonder because I must change this file in two of your client servers..

There are definitly changes in the function statistics() see the description.
It works with 3.6.0RC1 which seems not to be tagged or whatever..

If there is a solution without changing the source it is ok .

I added the Version of the function which was actual since 3.6.0RC as an attachment!

bearbeitet am: 02.07.04 22:08

bearbeitet am: 02.07.04 22:09

Ah, I see. The problem was introduced with revision 1.11 (Fixed lots of issues related to safe_mode and open_basedir. Should all work now!)

This patch should do the trick. Please confirm, thanks.

It works but:

This line makes no sense:
if(!ereg("^/", $logFileName)) $logFileName = PATH_site.$logFileName;

look at function getConfigArray().:
...
// STAT:
$theLogFile = $this->TYPO3_CONF_VARS['FE']['logfile_dir'].$this->config['config']['stat_apache_logfile'];
if ($this->config['config']['stat_apache'] &&
$this->config['config']['stat_apache_logfile'] &&
!strstr($this->config['config']['stat_apache_logfile'],'/') &&
@is_dir($this->TYPO3_CONF_VARS['FE']['logfile_dir']) && @is_file($theLogFile) && @is_writeable($theLogFile)) {
$this->config['stat_vars']['logFile'] = $theLogFile;

As you see:

This function checks if $logFileName exist, if not the needed $this->config['stat_vars'] is not filled so stat is not printed.
You have to add this in this function and have to set $this->config['stat_vars']['logFile'].
Byside - why use ereg and not strstr which is faster?

Additionaly an logmessage would be nice in this functiomn getConfigArray like:
else {
$GLOBALS['TT']->push('Could not set config array for statistic. (check logfile and permissions)','');
}

bearbeitet am: 05.07.04 11:15

You're right, thanks. I have attached a new patch. Didn't test it, so please confirm if this works...

As soon as Stucki's patch is confirmed to work, it can go into 3.7.

So anyone tested it?

Fixed now. Please test this in the 3.7RC!

The Bug appears again in 3.7.0

Why is the logPath checked with:
t3lib_div::isAllowedAbsPath

I dont want to log into the Pathsite!
Please remove this check, it makes bo sense here , right?

Greetings

It is still not possible to log outside the sitepath.

It is a securityhole to have the logfile available under the webrootpath.

It is possible if you add your logfile path to TYPO3_CONF_VARS[BE][lockRootPath].