Bug #14292
closed
template->endPage(): spurious </body>
Added by Martin Kutschker about 20 years ago.
Updated over 18 years ago.
Description
While startPage() doesn't output a body tag for docType "xhtml_frames" endPage() does.
This will invalidate the document if you don't want to have a body (ie are using only a frameset).
(issue imported from #M316)
Files
Attached patch.
Will there be any negative sideeffects? Masi, do you think it's backwards compatible?
Thanx, Ingmar. I don't think it should have any negative effects. But I'll have a look at this.
What just occured to me is that a user could set her own doctype (eg a custom XHTML DTD or simply HTML 4.0/frameset - mind that HTML4 has also 3 DTDs!) also would get a </body>. I guess it's good enough for 3.6.x (3.7.x as well?), but perhaps we can think of something better for future releases.
Hi Masi,
Attached a new patch, my previous patch was done a bit too fast, it even supressed the </html> tag for xhtml_frames.
I guess it's good enough for 3.6.x (3.7.x as well?),
but perhaps we can think of something better for future releases.
Maybe a class variable "var $bodyTag" that would trigger starting end ending body tag?
For backwards compatibility startPage() would have to set $this->bodyTag to FALSE if the doctype is xhtml_frames.
cheers,
Ingmar
I like the $bodyTag thingy and agree with the point on backwards compatibility.
Also available in: Atom
PDF