Feature #14458
closeddisplay titles of mm-related records -> patch
0%
Description
I made a small patch, to display the titles of mm-related records in lists in the BE. (instead of the hardcoded "N/A")
any chances to integrate this to the core ?
greets
rupi
the concerned files are:
typo3/class.db_list_extra.inc
typo3/sysext/cms/layout/class.tx_cms_layout.php
t3lib/class.t3lib_befunc.php
(issue imported from #M624)
Files
Updated by Rupert Germann almost 20 years ago
the first diff-file does not work in "web/page"-view.
the second one, named "list_mmTable_titles_fixed.diff" works.
Updated by Rupert Germann almost 20 years ago
in the last diff-file version (v3) I removed the hardcoded tt_news tablenames, so it should work with all extension tables now.
Updated by Rupert Germann almost 20 years ago
changes in v4: substituted the hardcoded column title with $TCA[$theColConf['foreign_table']]['ctrl']['label']
thx volker, for his hints ;-)
Updated by Rupert Germann almost 20 years ago
and again..
v5 has now all hardcoded column titles removed - really ! .
not my day today... ;-)
Updated by Michael Stucki almost 20 years ago
This patch looks very good! I'll send it to Kasper for final reviewal but I think it shouldn't be a problem to get this in.
Rupert: Is it ok if I remove the obsolete patches?
Updated by Michael Stucki almost 20 years ago
New patch, added suggestion by Volker Graubaum.
Updated by Rupert Germann almost 20 years ago
hi stucki,
remove them ;-)
thx.
another question:
any idea how to implement this in older TYPO3 versions without "Xclass"ing t3lib_befunc ? i think this will possibly cause some incompatibilities with other extensions doing the same.
Updated by Michael Stucki almost 20 years ago
you could patch them... I don't think there will be any updates for versions except 3.7...
Updated by Michael Stucki almost 20 years ago
Rupert,
I got a feedback from Kasper:
--- cut ---
+ '',$orderBy=$TCA[$theColConf['foreign_table']]['ctrl']['label']
I can't see why this makes sense; Why $orderBy=.... , why not just set
the label field?
--- cut ---
I don't think this is neccessary, is it?
- michael
Updated by Rupert Germann almost 20 years ago
hi stucki,
the "$orderBy=" is completely unnessecary. (removed it)
but I found another thing: deleted records are still shown.
I added a new patch which contains a "deleteClause" in the where-part.
maybe this one (v7) is it finally ;-)
rupi
Updated by Michael Stucki almost 20 years ago
maybe this one (v7) is it finally ;-)
Definitely not, but it's worth the try ;-)
Look at it again, it's not enough to remove just "$orderBy=", you'll have to remove the rest of the line, too...
Anyway, I fixed this now and will submit it to CVS shortly...
Merry Christmas!
- michael