Project

General

Profile

Actions

Feature #14458

closed

display titles of mm-related records -> patch

Added by Rupert Germann almost 20 years ago. Updated over 18 years ago.

Status:
Closed
Priority:
Should have
Category:
Backend API
Target version:
-
Start date:
2004-12-18
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

I made a small patch, to display the titles of mm-related records in lists in the BE. (instead of the hardcoded "N/A")

any chances to integrate this to the core ?

greets
rupi

the concerned files are:
typo3/class.db_list_extra.inc
typo3/sysext/cms/layout/class.tx_cms_layout.php
t3lib/class.t3lib_befunc.php
(issue imported from #M624)


Files

Actions #1

Updated by Rupert Germann almost 20 years ago

the first diff-file does not work in "web/page"-view.
the second one, named "list_mmTable_titles_fixed.diff" works.

Actions #2

Updated by Rupert Germann almost 20 years ago

in the last diff-file version (v3) I removed the hardcoded tt_news tablenames, so it should work with all extension tables now.

Actions #3

Updated by Rupert Germann almost 20 years ago

changes in v4: substituted the hardcoded column title with $TCA[$theColConf['foreign_table']]['ctrl']['label']

thx volker, for his hints ;-)

Actions #4

Updated by Rupert Germann almost 20 years ago

and again..
v5 has now all hardcoded column titles removed - really ! .

not my day today... ;-)

Actions #5

Updated by Michael Stucki almost 20 years ago

This patch looks very good! I'll send it to Kasper for final reviewal but I think it shouldn't be a problem to get this in.

Rupert: Is it ok if I remove the obsolete patches?

Actions #6

Updated by Michael Stucki almost 20 years ago

New patch, added suggestion by Volker Graubaum.

Actions #7

Updated by Rupert Germann almost 20 years ago

hi stucki,
remove them ;-)
thx.

another question:
any idea how to implement this in older TYPO3 versions without "Xclass"ing t3lib_befunc ? i think this will possibly cause some incompatibilities with other extensions doing the same.

Actions #8

Updated by Michael Stucki almost 20 years ago

you could patch them... I don't think there will be any updates for versions except 3.7...

Actions #9

Updated by Michael Stucki almost 20 years ago

Rupert,

I got a feedback from Kasper:

--- cut ---
+     '',$orderBy=$TCA[$theColConf['foreign_table']]['ctrl']['label']

I can't see why this makes sense; Why $orderBy=.... , why not just set
the label field?
--- cut ---

I don't think this is neccessary, is it?

- michael

Actions #10

Updated by Rupert Germann almost 20 years ago

hi stucki,
the "$orderBy=" is completely unnessecary. (removed it)

but I found another thing: deleted records are still shown.
I added a new patch which contains a "deleteClause" in the where-part.

maybe this one (v7) is it finally ;-)

rupi

Actions #11

Updated by Michael Stucki almost 20 years ago

maybe this one (v7) is it finally ;-)

Definitely not, but it's worth the try ;-)
Look at it again, it's not enough to remove just "$orderBy=", you'll have to remove the rest of the line, too...

Anyway, I fixed this now and will submit it to CVS shortly...

Merry Christmas!
- michael

Actions #12

Updated by Michael Stucki almost 20 years ago

Finally fixed.

Actions

Also available in: Atom PDF