Bug #14523: Cygwin support in Typo3 is missing. - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #14523

closed

Cygwin support in Typo3 is missing.

Added by old_akio about 19 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Mathias Schreiber

Category:

Backend API

Target version:

Start date:

2005-02-02

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.1

PHP Version:

4.3

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Cygwin is a GNU UNIX emulation layer for Windows systems. It behaves like a real UNIX system. As that, it should be recognized by Typo3.

Critical lines are:

line 65 in t3lib/thumbs.php
line 70 in typo3/init.php
line 56 in typo3/sysext/cms/tslib/index_ts.php
line 61 in typo3/sysext/cms/tslib/showpic.php

These should be changed to

define('TYPO3_OS', [-- old code --]&&!stristr(PHP_OS,'cygwin')?'WIN':'');
(issue imported from #M735)

Actions

Copy link

Updated by Riccardo De Contardi over 10 years ago

Target version deleted (0)

As far as I can see in TYPO3 6.1 the string "define('TYPO3_OS'" is present only in the file /typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php

// Operating system identifier
// Either "WIN" or empty string
define('TYPO3_OS', self::getTypo3Os());

The same file contains:

/**
     * Determine the operating system TYPO3 is running on.
     *
     * @return string Either 'WIN' if running on Windows, else empty string
     */
    static protected function getTypo3Os() {
        $typoOs = '';
        if (!stristr(PHP_OS, 'darwin') && stristr(PHP_OS, 'win')) {
            $typoOs = 'WIN';
        }
        return $typoOs;
    }

I guess the bug is still valid

Actions

Copy link

Updated by Mathias Schreiber over 9 years ago

Description updated (diff)
Status changed from New to Needs Feedback
Assignee set to Mathias Schreiber
Is Regression set to No

Does cygwin offer symlink support?
If so, I'm fine with the change and will get this in.

Actions

Copy link

Updated by Frederic Gaus about 9 years ago

https://cygwin.com/cygwin-ug-net/using.html#pathnames-symlinks

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36765

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36765

Actions

Copy link