Bug #14672
closed
class.tslib_pibase.php: Improve list of result pages
0%
Description
This patch does the following:
1. Only display the list of pages if there actually is more than one page.
2. Don't link to the current page (usability!).
3. Remove the nowrap attribute (it isn't allowed in XHTML 1.0strict). Instead, we disallow wrapping by using nbsp instead of space.
4. Make the code more readable and add comments.
The patch is against the current CVS pull with the patch from bug 0000980 applied.
What do I need to do to get this reviewed and checked in?
(issue imported from #M981)
Files
Updated by Oliver Klee over 19 years ago
Um, sorry, this should be filed for frontend, not backend.
Updated by Oliver Klee over 19 years ago
Oops, there is a typo in the patch:
// Only display the list of result pages if there if more than one list
if -> is
Updated by Oliver Klee over 19 years ago
Kasper's note on this bug:
- I will not change behaviour that the current page is not linked. Just
because you don't like it, someone else might just do and therefore such
a change will a) either have to be configurable or b) agreed on from a
larger group of people saying that is the way to go.
- the nowrap="nowrap" attribute must be replaces by something else,
possibility is ' style="white-space: nowrap;"'
Updated by Oliver Klee over 19 years ago
The problem with a link to the current page is not merely about liking it or not, it's a major usability bloober. See item 10 on http://www.useit.com/alertbox/20031110.html for this.
The nowrap attribute has indeed been replaced by something: I've replaced the only character that allows wrapping (the space betwwen "page" and the page number) with a non-breaking space, so that it doesn't wrap (linebreak).
Updated by Mathias Schreiber over 18 years ago
TYPO3 Version too old.
The reported version is no longer maintained.
If this bug still persists in 4.0.1, please re-open it again and set the field "Product Version" to the corresponding version.