Project

General

Profile

Actions

Feature #14674

closed

t3lib_div::intInRange with "rounded" default max value

Added by Bernhard Kraft over 19 years ago. Updated over 18 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2005-04-15
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The method t3lib_div::intInRange takes a argument $max=2000000000 ... this is approximately the maximum value allowed for a signed integer and doesn't look professional. Should change it to : 0x7fffffff which is one before -1 and equals to 2147483647.

(issue imported from #M984)


Files

patch.t3lib_div_intInRange_max.diff (810 Bytes) patch.t3lib_div_intInRange_max.diff Administrator Admin, 2005-04-15 13:43
Actions #1

Updated by Bernhard Kraft over 19 years ago

The attached patch shows what is needed to be done.

Actions #2

Updated by Ingmar Schlecht over 19 years ago

Because I'm not used to it, entering a number the "0x..." way looks confusing to me.
IMHO you should better change it to $max=2147483647 (which admittedly doesn't look much less confusing) or just leave it the way it is.

Anyway, just send a patch to Kasper, ask for his "Go!" and commit it yourself.

Actions #3

Updated by Bernhard Kraft over 19 years ago

Was changed in CVS.

Actions

Also available in: Atom PDF