Bug #15248: When deleting a record in the BE, MsgBox should show the record label - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #15248

closed

When deleting a record in the BE, MsgBox should show the record label

Added by Oliver Klee almost 19 years ago. Updated over 14 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Martin Kutschker

Category:

Target version:

Start date:

2005-11-30

Due date:

% Done:

Estimated time:

TYPO3 Version:

4.3

PHP Version:

4.3

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

When I delete a record in the BE in Web > List, I get a message box wit the following text:

Are you sure you want to delete this record?
[Cancel] [OK]

Usability-wise, this could be improved by providing the record label (or the title):

Are you sure you want to delete the record "My Record 1"?
[Cancel] [OK]

In my case, I use a 100dpi display in which the fixed-size fonts of Typo3 are quite small (and even if I increase the font size, the icons stay small), so that I'm not always sure whether I have clicked in the right row. Here it would help if the message box told me which record I'm about to delete. (I'm sure that I want to delete something; I'm just not sure I've clicked on the right record.)

(issue imported from #M1957)

Files

Download all files

delete_patch.txt (1.29 KB) delete_patch.txt		Administrator Admin, 2008-08-29 10:47
delete_patch_2.txt (1.56 KB) delete_patch_2.txt		Administrator Admin, 2008-08-29 12:11
delete_warning_newmsg.diff (2.25 KB) delete_warning_newmsg.diff		Administrator Admin, 2008-08-29 21:24

Actions

Copy link

Updated by Oliver Klee almost 19 years ago

For this, sysext/cms/layout/db_layout.php probably needs to be changed. I still don't know where the change needs to go exactly in all these long functions and magic numbers.

Actions

Copy link

Updated by Sebastian Kurfuerst almost 19 years ago

I think typo3/sysext/cms/layout/db_layout.php and typo3/alt_doc.php need to be changed. Just search for deleteRecord inside there to find the JS function.

Maybe it can be changed to use the following:

Table:uid: Are you sure this record can be deleted? (the same text as before, just prefixed with table:uid) - This is easier to do I think...
Anyway I am not sure if this is bad from a usability side. Any comments?
Greets, Sebastian

Actions

Copy link

Updated by Oliver Klee almost 19 years ago

I've just looked through the user interface design guidelines of Windows, Maxc, KDE and Gnome. Those that say something about deleting elements use the following form:

Are you sure you want to delete the record "My Record 1"?

I propose using sprintf to place the element name in the string.

Some KDE apps also use the following form (although I suppose they don't do it that way to improve usability but because it was about 3 lines less to code):

Are you sure you want to delete the following record?
My Record 1

(If JavaScript provided custom buttons labels for alerts, we also should have "Cancel/Delete" buttons instead of "Cancel/OK", but AFAIK JavaScript doesn't support this.)

Actions

Copy link