Project

General

Profile

Actions

Feature #15524

closed

Moving all HTML fromtx_cssstyledcontent_pi1 to TS

Added by John Angel about 18 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
Content Rendering
Target version:
-
Start date:
2006-01-28
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

It would be great to move all HTML code from tx_cssstyledcontent_pi1 to TS for TYPO3 4 final release.

I want to make file uploads look like Unordered list:
<UL><LI>...<LI>...</UL>

Since tx_cssstyledcontent_pi1 has hard-coded HTML (instead of using
stdWrap), there is no TS solution for this.

(issue imported from #M2421)


Files

2421_movingHTMLoutOfCSC.patch (5.12 KB) 2421_movingHTMLoutOfCSC.patch Administrator Admin, 2009-05-13 10:26
bug2421-renderUploads.diff (7.83 KB) bug2421-renderUploads.diff Administrator Admin, 2009-05-15 12:07

Related issues 4 (0 open4 closed)

Related to TYPO3 Core - Feature #15943: Render bullet lists (tt_content.bullets) with TypoScriptClosedSteffen Kamper2006-03-29

Actions
Related to TYPO3 Core - Bug #20042: render_uploads description is processed by htmlspecialchars() hard codedClosed2009-02-18

Actions
Has duplicate TYPO3 Core - Feature #16075: render_uploads should be more flexibleClosed2006-04-20

Actions
Has duplicate TYPO3 Core - Feature #19058: render_uploads / filelinks - move html from php to typoscriptClosed2008-07-03

Actions
Actions #1

Updated by Stefano Cecere about 18 years ago

i agree with you, angel_john
could you at least list here all the hardcoded html in tx_cssstyledcontent_pi1 ?

Actions #2

Updated by John Angel about 18 years ago

class.tx_cssstyledcontent_pi1.php: lines 329 - 364

// Now, lets render the list!
$tRows = array();
foreach($filesData as $key => $fileD) {

// Setting class of table row for odd/even rows:
$oddEven = $key%2 ? 'tr-odd' : 'tr-even';

// Render row, based on the "layout" setting
$tRows[]='
<tr class="'.$oddEven.'">'.($type>0 ? '
<td class="csc-uploads-icon">
'.$fileD['linkedFilenameParts']0.'
</td>' : '').'
<td class="csc-uploads-fileName">
<p>'.$fileD['linkedFilenameParts']1.'</p>'.
($fileD['description'] ? '
<p class="csc-uploads-description">'.htmlspecialchars($fileD['description']).'</p>' : '').'
</td>'.($this->cObj->data['filelink_size'] ? '
<td class="csc-uploads-fileSize">
<p>'.t3lib_div::formatSize($fileD['filesize']).'</p>
</td>' : '').'
</tr>';
}

// Table tag params.
$tableTagParams = $this->getTableAttributes($conf,$type);
$tableTagParams['class'] = 'csc-uploads csc-uploads-'.$type;
// Compile it all into table tags:
$out = '
&lt;table &#039;.t3lib_div::implodeAttributes($tableTagParams).&#039;&gt;
'.implode('',$tRows).'
&lt;/table&gt;';
Actions #3

Updated by Administrator Admin about 18 years ago

You can use the extension CSS_filelinks meanwhile...

Actions #4

Updated by Ernesto Baschny about 18 years ago

This seem to be a task for TYPO3 4.1 (or 4.5?). If someone could send some patches to resolve the issues, it would help.

Actions #5

Updated by Ernesto Baschny almost 15 years ago

I just presented my suggestion for this in the core list.

Actions #6

Updated by Ernesto Baschny almost 15 years ago

Commited to trunk (will be in 4.3.0), rev. 5655.

Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF