Project

General

Profile

Actions

Bug #15898

closed

Cropscale fails, if one dimesion has already right size

Added by Stefan Geith over 18 years ago. Updated over 18 years ago.

Status:
Closed
Priority:
Should have
Category:
Communication
Target version:
-
Start date:
2006-04-07
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.0
PHP Version:
4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Gropscale fails, if
- width has already the right size and height mus be reduced
or
- height has already the right size and widthmus be reduced

Solution:

Change class.t3lib_stdgraphic.php line 2156 from
if ($wh_noscale && !$params && !$frame && $newExt==$info2 && !$mustCreate) {
to line
if ($wh_noscale && !$data['crs'] && !$params && !$frame && $newExt==$info2 && !$mustCreate) {

(issue imported from #M3162)


Files

TSref-change-cropcale.txt (1.54 KB) TSref-change-cropcale.txt Administrator Admin, 2006-04-18 15:36
Actions #1

Updated by Ingmar Schlecht over 18 years ago

Hi Bernhard,

this is another one you might want to look at.

If not, just unassign the bug again.

cheers
Ingmar

Actions #2

Updated by Bernhard Kraft over 18 years ago

Ok ....

What I did:

So my final conclusion is:

I send a diff with your suggestion to the core list and will commit it to CVS (As I have taken care of the GIFBUILDER somehow ...)

We (meaning initially you :) MUST (!!) write documentation for this feature !

A feature which isn't documented anywhere will never get used.
So write a a little textfiles containig the changes in TSref ... you will have to change the
text for the width/height field of IMAGE .... be sure to explain it in an easily understandable form (the posting in .dev is a little bit confusing) and probably even give 1 or 2 example !

thx Stefan for this contribution !!

Actions #3

Updated by Stefan Geith over 18 years ago

1) I would like to add Documentation, but I don't know where -
The text of TSref / imgResource / width/height should be changes;
(I will upload a Text-FIle here with suggested changes, but
cropscale isn't easy to explain - at least in english for non native speakers...)
2) Have you seen this: http://www.geithware.de/test/cropscale.html ?
There are some examples, on how it works;
3) Maybe you are able to change the descriprion to make it clearer ?

Actions #4

Updated by Martin Kutschker over 18 years ago

Fixed in CVS.

Actions

Also available in: Atom PDF