Bug #15929
closed
In some places TYPO3 inserts & instead of & in links
0%
Description
In /t3lib/class.t3lib_tstemplate.php around line 1362 there're some lines which insert & instaed of the specialchar()ed & in links when adding &type to an URL
(issue imported from #M3031)
Files
Updated by Ingmar Schlecht over 18 years ago
Hi Ingo,
thanks for the bug report!
Could you provide a patch?
cheers,
Ingmar
Updated by Ingo Renner over 18 years ago
Hey Ingmar,
I talked to Stucki about it before adding the bug.
At the moment I'm too busy with getting a project finished which is over due already.
That's why Stucki asked me to open the bug as I wouldn't be able to provide a patch before the weekend.
Sorry about that....
Updated by Ingmar Schlecht over 18 years ago
No worries, this bug is not too critical anyway so it's not a 4.0 release blocker.
Good luck for the project you're working on!
cheers,
Ingmar
Updated by Ingo Renner over 18 years ago
Hi Stucki, hi Ingmar,
hier der Patch...
Updated by Michael Stucki over 18 years ago
Hi Ingo,
I think this is not a bug. tstemplate->linkData does not neccessarily work with HTML output only. The ampercands should therefore be htmlspecialchar'ed in the function that calls this method, not directly in here.
I expect it is a bug inside a specific extension, but it must definitely not be changed in here!
Updated by Ingo Renner over 18 years ago
Hey Michael,
if you think so I'm fine with that. I haven't had the time to check where that function is used elsewhere.
Of course adding a htmlspecialchars() to the extension would do the trick...
Updated by Michael Stucki over 18 years ago
Exactly. htmlspecialchars() is always and only called right before it outputted.
Updated by Ingmar Schlecht over 18 years ago
I agree with Michael that hsc() should not be applied to the links genereated at that point.
In TYPO3, generally values are hsc()ed directly before outputting it to the browser.
cheers
Ingmar