Project

General

Profile

Actions

Bug #16044

closed

Wrong parameters in implode function

Added by Jan Bednarik over 18 years ago. Updated over 18 years ago.

Status:
Closed
Priority:
Should have
Category:
Extension Manager
Target version:
-
Start date:
2006-04-13
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.0
PHP Version:
4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

There's a bug in typo3/mod/tools/em/class.em_index.php.

On line 1391 there's a call:
$mirrors = implode(gzfile($mfile));
and on 1423 there's
$content .= $this->xmlhandler->parseExtensionsXML(implode(gzfile(...)));

Which is obviously wrong, as implode function needs 2 params.

Strange is, that with PHP5 everything works OK, but with PHP 4.1.x it doesn't work.

(issue imported from #M3253)

Actions #1

Updated by Martin Kutschker over 18 years ago

See http://at.php.net/manual/en/function.implode.php

Note: implode() can, for historical reasons, accept its parameters in either order. For consistency with explode(), however, it may be less confusing to use the documented order of arguments.

Note: As of PHP 4.3.0, the glue parameter of implode() is optional and defaults to the empty string(''). This is not the preferred usage of implode(). We recommend to always use two parameters for compatibility with older versions.

Conclusion: it breaks only in PHP 4.

Actions #2

Updated by Karsten Dambekalns over 18 years ago

Is already fixed in current SVN code...

Actions

Also available in: Atom PDF