Project

General

Profile

Actions

Bug #16791

closed

New default behaviour for PAGE_TARGET

Added by Benni Mack over 17 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Should have
Category:
Content Rendering
Target version:
-
Start date:
2006-12-15
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.1
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Hey,

I am developing a lot of web-sites with TYPO3 now, and one thing that
annoys me is the Template Constant "PAGE_TARGET" which is the "Default
target for internal links". Hmm, this was indeed very very useful back
with TYPO3 3.5 when a lot of websites were built with frames. But
nowadays: who does websites still with frames? I think it's definitely
not the majority. That's why I would suggest to change the default
behaviour to "".
Right now, the default behaviour is "PAGE_TARGET = page", but I would
just change the static code to "PAGE_TARGET = " for new installations (=
for 4.1), so a lot of admins don't have to think about this annoying
thing every time. After all, we want to help new people getting a site
up and running with almost no configuration in very short time.

http://lists.typo3.org/pipermail/typo3-dev/2006-December/021379.html

This is how it is solved:

Add the following lines to
typo3/sysext/css_styled_content/static/constants.txt
----------------
[compatVersion = 4.1.0]

PAGE_TARGET =

[end]
----------------
(issue imported from #M4662)


Files

page_target_default.diff (1.46 KB) page_target_default.diff Administrator Admin, 2007-10-23 17:53
page_target_default_compat.diff (2.91 KB) page_target_default_compat.diff Administrator Admin, 2007-10-23 21:20
page_target_default_compat_new.diff (2.54 KB) page_target_default_compat_new.diff Administrator Admin, 2007-10-27 21:36
Actions #1

Updated by Benni Mack over 17 years ago

crap, the above was wrong. This code actually works. I tried it out. Sorry for the re-post.

--------------------
[compatVersion = 4.1]

  1. cat=advanced/links; type=small; label= Target for internal links: Should match the name of the content PAGE-object in TypoScript when used with frames. Most cases: Set to "page" if you have frames in the template. If not, set to "" (empty)
    PAGE_TARGET =

[end]
--------------------

Actions #2

Updated by Benni Mack over 17 years ago

Is this going into 4.1? I haven't heard a response from the developers yet.

Actions #3

Updated by Ernesto Baschny about 17 years ago

I would +1 to it. I think Stucki is already typing in the code for it as we speak! ;)

Actions #4

Updated by Michael Stucki about 17 years ago

The problem is not to change the template, but to mention this in the update wizard somehow. I'm still fighting with that... :-)

Actions #5

Updated by Ingmar Schlecht about 17 years ago

Very useful change, I'd like to see this in 4.2!

cheers
Ingmar

Actions #6

Updated by Sebastian Kurfuerst about 17 years ago

Hm I think it is a good idea to have it in 4.1... :-( that we have feature freeze

Greets,
Sebastian

Actions #7

Updated by Steffen Kamper about 17 years ago

please do it also this for

content.pageFrameObj =

this is used in Sitemap/Menu-CE and is very annoying that default is

content.pageFrameObj = page

or change it in setup to use here the Constant of PAGE_TARGET

Actions #8

Updated by Steffen Kamper over 16 years ago

I applied a patch which
1) sets PAGE_TARGET = (in constants)

2) uses PAGE_TARGET instead of pageFrameObj in tt_content.menu (in setup)

i will write a RFC too.

Actions #9

Updated by Steffen Kamper over 16 years ago

ok, as Benny mentioned i changed the setting to compat version (4.2.0)
I also wrote a comment for the update wizard, hope to fit the needs Michael was talking of.
Patchfile now is page_target_default_compat.diff

Actions #10

Updated by Benni Mack over 16 years ago

Attached patch commited to trunk (rev 2625)

Actions #11

Updated by Chris topher almost 10 years ago

  • Target version deleted (0)
  • TYPO3 Version set to 4.1
  • Is Regression set to No
Actions

Also available in: Atom PDF