Project

General

Profile

Actions
Copy link

Bug #17023

closed

JSMENU produces error if using baseurls

Added by Jens Köster almost 18 years ago. Updated over 16 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Oliver Hader
Category:
Communication
Target version:
-
Start date:
2007-02-21
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.1
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The JSMENU does not work with baseurls set i.e. in realURL enviroments

The reasons for this:
1. Array property for number of elements is not .size but .length in t3lib/jsfunc.menu.js
2. the $GLOBALS['TSFE']->baseUrlWrap() has to be applied to nonempty URLs in typo3/sysext/cms/tslib/class.tslib_menu.php. Otherwise the javascript-code will not work properly on menu entries with noLink=1 Instead of staying at the current url, the baseurl is loaded.

(issue imported from #M5048)

Files

Download all files
patchfile.patch (2.89 KB) patchfile.patch Administrator Admin, 2007-02-21 17:36
0005048.patch (2.15 KB) 0005048.patch Administrator Admin, 2007-02-24 15:13
Actions
Copy link
 #1

Updated by Oliver Hader almost 18 years ago

Could you please provide a small portion of TypoScript to reproduce and test this on your patch? Thanks!

Actions
Copy link
 #2

Updated by Jens Köster almost 18 years ago

lib.pulldownNav = HMENU
lib.pulldownNav {
special = directory
special.value = 86
1=JSMENU
1 {
levels = 3
1.noLink = 1
2.noLink = 1
3.noLink = 1
}
}

config{
simulateStaticDocuments = 0
baseURL = http://baseurl
tx_realurl_enable = 1
prefixLocalAnchors = all
}

  1. this config block causes the problem - check out the generated javascript
  2. eid1=JSmenu.add(0,0,0,'title','[you will find the baseurl here]','');
Actions
Copy link
 #3

Updated by Oliver Hader over 17 years ago

Your patch fixed the problem. Thanks!
However, I added a new patch with some cleaning in the affected JavaScript part.
I'm not sure if it could happen in a JSMENU that an item is not linked but requested to use the baseURL?

The call baseUrlWrap was last changed by Bernhard in revision 1111
(see http://svn.t3.digitaldistrict.de/cgi-bin/trac.cgi/changeset/4184 ).

Actions
Copy link
 #4

Updated by Oliver Hader over 17 years ago

Committed to SVN
  • TYPO3_4-1 (rev. 2393)
  • Trunk (rev. 2394)
Actions
Copy link

Also available in: Atom PDF