Project

General

Profile

Actions

Bug #17056

closed

Error in "Who is online" in T3 4.1 rev. 2163

Added by Matthias Kall over 17 years ago. Updated over 17 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2007-02-28
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.1
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With the Bugfix from Bug 5073 a little typo made it into the trunk.
It causes the "Who is online" module to show only the current user if $GLOBALS['TYPO3_CONF_VARS']['BE']['sessionTimeout'] is a string (for every installation where the value was modified in the install-tool).

See attached patch.

(issue imported from #M5092)


Files

5092.diff (570 Bytes) 5092.diff Administrator Admin, 2007-02-28 19:50
bug_5092_corrected.diff (620 Bytes) bug_5092_corrected.diff Administrator Admin, 2007-02-28 21:23
bug_5092_v3.diff (824 Bytes) bug_5092_v3.diff Administrator Admin, 2007-03-01 08:01

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #17042: Tools->User Admin-> List users online is brokenClosedOliver Hader2007-02-26

Actions
Actions #1

Updated by Matthias Kall over 17 years ago

My first diff was the wrong way (diff -ru NEW OLD)
Now it works.
Sorry.

Actions #2

Updated by Steffen Müller over 17 years ago

string is not allowed in $GLOBALS['TYPO3_CONF_VARS']['BE']['sessionTimeout']
Integer only.

Actions #3

Updated by Matthias Kall over 17 years ago

The install tool saves the value as
$GLOBALS['TYPO3_CONF_VARS']['BE']['sessionTimeout'] = '3600';
and not as
$GLOBALS['TYPO3_CONF_VARS']['BE']['sessionTimeout'] = 3600;

That's why php thinks it's a string.

Actions #4

Updated by Steffen Müller over 17 years ago

+1
I can reproduce this and the appended patch fixes the error.

Actions #5

Updated by Oliver Hader over 17 years ago

Thanks guys for making this out. The dot "." is a bug and the is_string should check against an integer. The new patch also fixes this behaviour.

Actions #6

Updated by Oliver Hader over 17 years ago

Committed to Trunk.

ChangeLog entry:
  • Fixed bug: #17056: Typo in Who is online (thanks to Matthias Kall)
Actions

Also available in: Atom PDF