Project

General

Profile

Actions

Bug #17673

closed

Performance enhancements in BE, part 1

Added by Dmitry Dulepov about 17 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Must have
Category:
-
Target version:
-
Start date:
2007-10-11
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.1
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Problem: dummy BE module with no code at all takes 1 second to load. I
started profiling and found that some functions do not process data
effectively. One of the most time consuming is
t3lib_extMgm::addToAllTCAtypes(). It loops over "types" array even if
there is no need for it and calls trim() several times on the same
variable. Though it all takes milliseconds, it is still 30% of all time
in request. I do not think it is acceptable. // Another time consuming function is t3lib_div:loadTCA(). I could optimize it too by using shortcuts to inside of TCA array. // Time numbers were 134 and 108ms for extMgm and t3lib_div, now they are 32 and 44ms. This is not a big change but these are the most time consuming functions, they take more than INSERT/UPDATE calls to MySQL! The more extensions are installed, the more time these functions take.

Solution: optimize function to skip loop when it is not necessary and use shortcuts to TCA array. Patches are supplied separately.
(issue imported from #M6508)


Files

perf1-before.png (10.4 KB) perf1-before.png Administrator Admin, 2007-10-11 16:29
perf1-after.png (10.1 KB) perf1-after.png Administrator Admin, 2007-10-11 16:29
em_perf_enh.patch (2.93 KB) em_perf_enh.patch Administrator Admin, 2007-10-11 16:29
t3lib_div_loadtca.patch (1.29 KB) t3lib_div_loadtca.patch Administrator Admin, 2007-10-11 16:29
Actions #1

Updated by Dmitry Dulepov about 17 years ago

I submitted this long time ago but I did not get enough +1s.

Actions #2

Updated by Ingo Renner almost 17 years ago

Any news Dmitry? Could ou maybe send some reminder to the core list?

Actions #3

Updated by Benni Mack almost 17 years ago

I just checked...

you sent this to core list, stucki said to commit as is and you did.
Was on 2007-07-12 btw.

Anyway, I also checked the attached patches with the latest 4.2 branch and they are in there already. So this issue is resolved IMHO with TYPO3 4.2alpha1.

Thanks a lot, Dmitry!

Actions #4

Updated by Ingo Renner almost 17 years ago

Benni, which revision?

Actions #5

Updated by Benni Mack almost 17 years ago

r2402 | liels_bugs | 2007-07-12 13:36:08 +0200 (Thu, 12 Jul 2007) | 1 line

Performance enhancement in t3lib/class.t3lib_div.php in function loadTCA

This is from the SVN log.

And it is in latest 4.2 branch.

Actions #6

Updated by Ingo Renner almost 17 years ago

already commited to svn

Actions

Also available in: Atom PDF