Project

General

Profile

Actions
Copy link

Bug #17922

closed

t3lib_htmlmail.php cleanup

Added by Benni Mack almost 17 years ago. Updated over 16 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Benni Mack
Category:
-
Target version:
-
Start date:
2007-12-15
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The file t3lib/class.t3lib_htmlmail.php did not have phpDoc style comments yet and was quite unusable for documentation purposes. I added minimal documentation and refactored some code, cleaned up some variable names, used foreach instead of the each-while() controls and made the code better to read. I also added "public" to every function to make it PHP5-like.

This patch is still untested, I'd be glad if someone could try it out.
(issue imported from #M6958)

Files

Download all files
20071214_htmlmail_cleanup.patch (66.5 KB) 20071214_htmlmail_cleanup.patch Administrator Admin, 2007-12-15 02:17
class.t3lib_htmlmail.patch (1.22 KB) class.t3lib_htmlmail.patch Administrator Admin, 2007-12-16 14:55
20071216_htmlmail_cleanup.patch (66.6 KB) 20071216_htmlmail_cleanup.patch Administrator Admin, 2007-12-16 17:17
20080108_htmlmail_cleanup.patch (66.6 KB) 20080108_htmlmail_cleanup.patch Administrator Admin, 2008-01-08 22:17
20080109_htmlmail_cleanup.patch (67.4 KB) 20080109_htmlmail_cleanup.patch Administrator Admin, 2008-01-09 16:24
20080115_htmlmail_cleanup.patch (67.3 KB) 20080115_htmlmail_cleanup.patch Administrator Admin, 2008-01-15 11:11

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Bug #17233: t3lib_htmlmail should have empty default valuesClosedBenni Mack2007-04-23

Actions
Has duplicate TYPO3 Core - Feature #14389: Enhancement to class.t3lib_htmlmail.phpClosedChris topher2004-11-15

Actions
Actions
Copy link
 #1

Updated by Stefano Cecere almost 17 years ago

good work Benjamin!

but i can't understand easily the purpose of
20071214_htmlmail_cleanup_nowhitespace.patch

:?

Actions
Copy link
 #2

Updated by Benni Mack almost 17 years ago

hey Stefano.

nowhitespace is just a patch create with the -uwb option to remove the whitespace changes (to make a review easier), apparently this did not change a lot so it really does not matter.

Have you tried the patch? Did it work?

Actions
Copy link
 #3

Updated by Stefano Cecere almost 17 years ago

no i didn't try it.. i just browsed the pach and looked good

maybe i'll try tomorrow

thanks Ben

Actions
Copy link
 #4

Updated by Stefano Cecere almost 17 years ago

hi Ben

i applied the patch and got 3 errors.

i apply here the patch to fix it

Actions
Copy link
 #5

Updated by Benni Mack almost 17 years ago

Hi Stefano,

thanks for reporting back. I uploaded a new version that includes your fixes. We still have to test this class to see if it works the exact same as the old one. Only then I can send it to the Core list.

Actions
Copy link
 #6

Updated by Benni Mack almost 17 years ago

I added the changes for the other issue (empty default values) in the latest version and also changed the tabs to spaces between

if (...)TAB{

if (...)SPACE{

Actions
Copy link

Also available in: Atom PDF