Project

General

Profile

Actions

Bug #17233

closed

t3lib_htmlmail should have empty default values

Added by John Angel over 17 years ago. Updated over 16 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2007-04-23
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.1
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In file class.t3lib_htmlmail.php, class t3lib_htmlmail have strange default values, like in the cartoon:

var $recipient = "";
var $subject = "This is the subject";
var $from_email = "";
var $from_name = "Mr. Sender";
var $replyto_email = "";
var $replyto_name = "Mr. Reply";
var $organisation = "Your Company";
var $mailer = "PHP mailer"; // X-mailer

All of them should be empty:

var $recipient = ""; // 
var $subject = ""; // This is the subject
var $from_email = ""; //
var $from_name = ""; // Mr. Sender
var $replyto_email = ""; //
var $replyto_name = ""; // Mr. Reply
var $organisation = ""; // Your Company
var $mailer = ""; // PHP mailer

(issue imported from #M5482)


Files

5482.diff (2.67 KB) 5482.diff Administrator Admin, 2007-05-02 11:38

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #17922: t3lib_htmlmail.php cleanupClosedBenni Mack2007-12-15

Actions
Has duplicate TYPO3 Core - Feature #14389: Enhancement to class.t3lib_htmlmail.phpClosedChris topher2004-11-15

Actions
Actions #1

Updated by Martin Kutschker over 17 years ago

I agree, the defaults are ridiculuous and its a PITA to make sure you empty them if you don't set them (eg the organization).

The only field which may still have a default is IMHO the mailer field. But I would change it to "TYPO3 x.y".

Actions #2

Updated by Ingo Renner over 17 years ago

here's a patch

Actions #3

Updated by Martin Kutschker over 17 years ago

Looks good.

Actions #4

Updated by Martin Holtz about 17 years ago

in the core, please

regareds,
martin

Actions #5

Updated by Oliver Hader about 17 years ago

Patch looks good: +1
Go ahead, Ingo! ;-)

Actions #6

Updated by Michael Stucki about 17 years ago

Hi Martin,

you can create your own RFC on the core list now! See http://news.typo3.org/news/article/core-development-mailinglist-now-open-for-community-involvement/

- michael

Actions #7

Updated by Michael Stucki about 17 years ago

Sending reminder to Martin Holtz.

Actions #8

Updated by Benni Mack almost 17 years ago

Guys, I added this issue to my patch (see related to)

Actions #9

Updated by Benni Mack almost 17 years ago

Fixed in Bug #17922

Actions

Also available in: Atom PDF