TYPO3 Core

good work Benjamin!

but i can't understand easily the purpose of
20071214_htmlmail_cleanup_nowhitespace.patch

:?

hey Stefano.

nowhitespace is just a patch create with the -uwb option to remove the whitespace changes (to make a review easier), apparently this did not change a lot so it really does not matter.

Have you tried the patch? Did it work?

no i didn't try it.. i just browsed the pach and looked good

maybe i'll try tomorrow

thanks Ben

hi Ben

i applied the patch and got 3 errors.

i apply here the patch to fix it

Hi Stefano,

thanks for reporting back. I uploaded a new version that includes your fixes. We still have to test this class to see if it works the exact same as the old one. Only then I can send it to the Core list.

I added the changes for the other issue (empty default values) in the latest version and also changed the tabs to spaces between

if (...)TAB{

if (...)SPACE{