Project

General

Profile

Actions

Bug #18395

closed

Yahoo, MSN, Ask.com and Alexa are not recognized in TypoScript robot condition

Added by Peter Knoell over 16 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2008-03-07
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.1
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you use Typoscript to deliver special content for search engines you have to rely on the funktion [device=robot]

In class.t3lib_matchcondition.php the function checking for the crawlers ist just not up to date.

Three lines have to be added:

strstr($agent, 'teoma') || // ask.com
strstr($agent, 'slurp') || // Yahoo
strstr($agent, 'msnbot') || // MSN

It has to be like this:

if( strstr($agent, 'crawler') ||
strstr($agent, 'spider') ||
strstr($agent, 'googlebot') ||
strstr($agent, 'searchbot') ||
strstr($agent, 'infoseek') ||
strstr($agent, 'altavista') ||
strstr($agent, 'teoma') ||
strstr($agent, 'slurp') ||
strstr($agent, 'msnbot') ||
strstr($agent, 'diibot')) {
return 'robot';
}

(issue imported from #M7787)


Files

0007787.patch (1.5 KB) 0007787.patch Administrator Admin, 2008-03-08 11:57

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #14520: Newer mobile phones are not recognized by condition [device = wap]ClosedChristian Kuhn2005-02-01

Actions
Actions #1

Updated by Christian Kuhn over 15 years ago

There was a very similar request in #14520

To not clutter this function even more it is possible since r1421 to use a hook in function whichDevice for better device detection.

I suggest to resolve this issue with no change required and solve needed stuff with extensions.

Actions #2

Updated by Gerrit Code Review almost 13 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7717

Actions #3

Updated by Alexander Opitz over 11 years ago

  • Category deleted (Communication)
  • Status changed from Under Review to Closed
  • Target version deleted (0)

I'm fine with that what Christian Kuhn wrote. "I suggest to resolve this issue with no change required"

The gerrit code message is wrong it seems Tolleiv used false issue number.

Actions

Also available in: Atom PDF