Project

General

Profile

Actions

Bug #18456

closed

Page lock not released when error page was generated

Added by Christian Kuhn over 16 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Communication
Target version:
-
Start date:
2008-03-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If FE creates a error message (like "No template found"), a former acquired page Lock is not released.

This leads to 30 second delays when such a page is reloaded.

Attached patch adds a releasePageGenerationLock() to printError() in class.tslib_fe.php to fix this.

pageErrorHandler() probably also needs some additional calls.

(issue imported from #M7874)


Files

0007874.patch (1.6 KB) 0007874.patch Administrator Admin, 2008-03-17 12:12
Actions #1

Updated by Oliver Hader over 16 years ago

Hi Christian,
thanks for pointing that out! I have another method which does not require to release locks "manually" - e.g. if an extension exits to system while processing this won't be caught.

But, we could do this using the destructor of t3lib_lock, e.g.
class t3lib_lock {
public function __desctruct() {
$this->release();
}
}

I'm going to take care of this issue tomorrow.

Actions #2

Updated by Oliver Hader over 16 years ago

The attached patch adds a destructor to t3lib_lock which will release the lock when the locking object gets destroyed or also if the script execution was stopped by an exit-signal. Please test it!

Actions #3

Updated by Christian Kuhn over 16 years ago

Tested and works for me. Using a destructor for the locking object is much better.

Actions #4

Updated by Oliver Hader over 16 years ago

Committed to SVN TYPO3_4-2 (rev. 3454)

Actions

Also available in: Atom PDF